Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Mermaid JS character limit configurable #16513

Closed
moiflo033 opened this issue Jul 22, 2021 · 1 comment · Fixed by #16519
Closed

Make Mermaid JS character limit configurable #16513

moiflo033 opened this issue Jul 22, 2021 · 1 comment · Fixed by #16519

Comments

@moiflo033
Copy link

moiflo033 commented Jul 22, 2021 •
edited

  • Gitea version (or commit ref): 1.14.4
  • Git version: 2.30.2
  • Operating system: docker
  • Log gist:

Description

Currently the character limit is 5000 chars. This isn't enough for more complex diagrams. I understand the concern that mermaid.js might take to long with larger diagramms, hence why i'm suggesting to make it configurable.

Screenshots
@silverwind
Copy link
Member

Agree, the 5000 limit was ported from GitLab's implementation, we should add a config option for it.

zeripath added a commit to zeripath/gitea that referenced this issue Jul 22, 2021
@zeripath
Make Mermaid.js limit configurable
5a45258 
Add `MERMAID_MAX_SOURCE_CHARACTERS` to `[markup]` settings
to make the maximum size of a mermaid render configurable.

Fix go-gitea#16513

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Jul 22, 2021
Merged
techknowlogick pushed a commit that referenced this issue Jul 24, 2021
@zeripath @silverwind @lunny
Make Mermaid.js limit configurable (#16519)
f135a81 
* Make Mermaid.js limit configurable

Add `MERMAID_MAX_SOURCE_CHARACTERS` to `[markup]` settings
to make the maximum size of a mermaid render configurable.

Fix #16513

Signed-off-by: Andrew Thornton <art27@cantab.net>

* fixup! Make Mermaid.js limit configurable

* Update custom/conf/app.example.ini

Co-authored-by: silverwind <me@silverwind.io>

* Update docs/content/doc/advanced/config-cheat-sheet.en-us.md

Co-authored-by: silverwind <me@silverwind.io>

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this issue Aug 10, 2021
@zeripath @silverwind
@lunny @AbdulrhmnGhanem
Make Mermaid.js limit configurable (go-gitea#16519)
eaeba5b 
* Make Mermaid.js limit configurable

Add `MERMAID_MAX_SOURCE_CHARACTERS` to `[markup]` settings
to make the maximum size of a mermaid render configurable.

Fix go-gitea#16513

Signed-off-by: Andrew Thornton <art27@cantab.net>

* fixup! Make Mermaid.js limit configurable

* Update custom/conf/app.example.ini

Co-authored-by: silverwind <me@silverwind.io>

* Update docs/content/doc/advanced/config-cheat-sheet.en-us.md

Co-authored-by: silverwind <me@silverwind.io>

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Mermaid.js limit configurable zeripath/gitea
2 participants
@silverwind @moiflo033