Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Reference in new issue" original-poster tagging not working #17073

Closed
MrGussio opened this issue Sep 17, 2021 · 1 comment · Fixed by #17074
Closed

"Reference in new issue" original-poster tagging not working #17073

MrGussio opened this issue Sep 17, 2021 · 1 comment · Fixed by #17074

Comments

@MrGussio
Copy link
Contributor

MrGussio commented Sep 17, 2021 •
edited
Loading

Gitea Version

1.15.0

Git Version

2.27.0

Operating System

Windows Server 2019

How are you running Gitea?

We used the download from the Gitea website and are running it as a service on Windows, as described in the installation instructions.

Database

SQLite

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Description

When using the "Reference this issue"-feature for an existing issue, it creates a new issue by quoting the previous one. At the bottom of the issue, there is a reference to the original author. However, in our case, it does not tag it correctly: it takes the display name (so in my case it would print @Jelle%20Hulter instead of @jellehulter using my username).

I was unable to reproduce it on the demo site, somehow it shows the username there for issues instead of the display name/full name which is attached to the account. Tried committing a commit which used the same email as the Gitea account but that didn't help either.

After this, I noticed that our Gitea configuration had the DEFAULT_SHOW_FULL_NAME setting set to true which caused this change. Apparently, the "Reference this issue"-window uses this setting to determine if it should use either the username or the full name, while this should be just the display name.

Maybe this has already been fixed in the meanwhile, I tried taking a look in the PR and issue history but I was unable to find a similar issue.

Screenshots

gitea_issue_screenshot
Here, the username would be expected instead of the full name (and hence still the percentage-sign encoding of a space)
@MrGussio
Copy link
Contributor Author

After cloning and building it myself, I can confirm it is still the case in Gitea version 1.16.0+dev-252-gf96d0d3d5:
image

@MrGussio MrGussio mentioned this issue Sep 17, 2021
Merged
zeripath pushed a commit that referenced this issue Sep 18, 2021
@MrGussio
Fixed issue where creating a reference of an issue would create a tag…
b74a0f9 
… with the full name instead of the username if this is the default in the .ini file (#17074)

Adds an extra attribute to every issue comment containing the actual username, such that it can be used to tag the original author when clicking on "Reference in new issue" (#17073)

Fix #17073
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes username tagging in "Reference in new issue" MrGussio/gitea
1 participant
@MrGussio