Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Team review requests get deleted when team member submits unrelated review request #17251

Closed
jpraet opened this issue Oct 7, 2021 · 0 comments · Fixed by #17257
Closed

Team review requests get deleted when team member submits unrelated review request #17251

jpraet opened this issue Oct 7, 2021 · 0 comments · Fixed by #17257
Labels
type/bug
Milestone
1.15.4

Comments

@jpraet
Copy link
Member

jpraet commented Oct 7, 2021

Gitea Version

1.15.3

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

PostgreSQL

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Description

Team review requests unexpectedly get deleted when a team member submits any review in a (potentially unrelated) pull request.

It looks like the where clause to consider only the current PR is missing here:
https://github.com/go-gitea/gitea/blob/main/models/review.go#L444-L463

Screenshots

No response
jpraet added a commit to jpraet/gitea that referenced this issue Oct 7, 2021
@jpraet
Fix unwanted team review request deletion
8650efd 
Add missing issue_id = ? to where clause
Fixes go-gitea#17251
@jpraet jpraet mentioned this issue Oct 7, 2021
Merged
jpraet added a commit to jpraet/gitea that referenced this issue Oct 7, 2021
@jpraet
Fix unwanted team review request deletion
0fb2c76 
Add missing issue_id = ? to where clause
Fixes go-gitea#17251
@jpraet jpraet added the type/bug label Oct 7, 2021
@jpraet jpraet added this to the 1.15.4 milestone Oct 7, 2021
lafriks added a commit to jpraet/gitea that referenced this issue Oct 7, 2021
@lafriks
Merge branch 'main' into go-gitea#17251-team-review-deleted
691dcb2
6543 pushed a commit that referenced this issue Oct 7, 2021
@jpraet
Fix unwanted team review request deletion (#17257)
25a2000 
Add missing issue_id = ? to where clause
Fixes #17251
jpraet added a commit to jpraet/gitea that referenced this issue Oct 7, 2021
@jpraet
Merge branch 'release/v1.15' into backport-go-gitea#17251-team-review…
d46dfc2 
…-deleted
@jpraet jpraet mentioned this issue Oct 7, 2021
Merged
6543 pushed a commit that referenced this issue Oct 7, 2021
@jpraet
Fix unwanted team review request deletion (#17257) (#17264)
a1e57eb 
Add missing issue_id = ? to where clause
Fixes #17251
Chianina pushed a commit to Chianina/gitea that referenced this issue Oct 15, 2021
@jpraet
Fix unwanted team review request deletion (go-gitea#17257)
8f630f3 
Add missing issue_id = ? to where clause
Fixes go-gitea#17251
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.15.4
Development

Successfully merging a pull request may close this issue.

Fix unwanted team review request deletion jpraet/gitea
1 participant
@jpraet