Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji heavy_check_mark: shown as pink instead of green #17795

Closed
suchAdemon opened this issue Nov 24, 2021 · 1 comment · Fixed by #17797
Closed

Emoji heavy_check_mark: shown as pink instead of green #17795

suchAdemon opened this issue Nov 24, 2021 · 1 comment · Fixed by #17797
Labels

Comments

@suchAdemon
Copy link

Gitea Version

1.15.6

Operating System

Debian 10

Browser Version

Chrome 96.0.4664.45

Can you reproduce the bug on the Gitea demo site?

Yes

Description

I have seen that if I add :heavy_check_mark: to comments or something like that, it gets displayed in a different way based on the theme got selected, which leads to a miss understanding of it.

As you can see in the attached screenshots, it is green if the gitea theme is selected, but if you select the arc-green theme, it gets pink which leeds to a miss understanding of if

tested there as well: https://try.gitea.io/suchAdemon/test_sad

Screenshots

image
image

@silverwind
Copy link
Member

silverwind commented Nov 24, 2021

Some emoji fonts like Apple's render this emoji in monochrome black, this is why we had it inverted using a CSS filter for better contrast. See https://emojipedia.org/check-mark/ for example renderings. I think it should be possible to change the invertion to preserve color, e.g. filter: invert(100%) hue-rotate(180deg) to fix this.

silverwind added a commit to silverwind/gitea that referenced this issue Nov 24, 2021
silverwind added a commit to silverwind/gitea that referenced this issue Nov 24, 2021
lunny pushed a commit that referenced this issue Nov 24, 2021
wxiaoguang pushed a commit that referenced this issue Nov 24, 2021
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants