Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed table sort #17884

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Fixed table sort #17884

merged 1 commit into from
Dec 2, 2021

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Dec 2, 2021

With the changes from #17699 the data- prefix is needed.

@KN4CK3R KN4CK3R added type/bug topic/ui Change the appearance of the Gitea UI labels Dec 2, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 2, 2021
silverwind
silverwind approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I don't know how I missed that. Just double checked, it's the only such case from the PR.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 2, 2021
@wxiaoguang wxiaoguang merged commit fbf3208 into go-gitea:main Dec 2, 2021
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 2, 2021
@wxiaoguang wxiaoguang added this to the 1.16.0 milestone Dec 2, 2021
@KN4CK3R KN4CK3R deleted the fix-tablesort branch December 2, 2021 20:38
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@KN4CK3R
Added missing data- prefix. (go-gitea#17884)
eb95fd2
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@KN4CK3R @silverwind @wxiaoguang @GiteaBot