Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong redirect on org labels #18128

Merged
merged 5 commits into from
Dec 30, 2021
Merged

Fix wrong redirect on org labels #18128

merged 5 commits into from
Dec 30, 2021

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Dec 29, 2021

Looks like a copy/paste error from repo.InitializeLabels.

@KN4CK3R KN4CK3R added this to the 1.16.0 milestone Dec 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021 •
edited
Loading

Codecov Report

Merging #18128 (e60c246) into main (626b107) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18128      +/-   ##
==========================================
- Coverage   44.95%   44.94%   -0.02%     
==========================================
  Files         825      825              
  Lines       91559    91559              
==========================================
- Hits        41162    41151      -11     
- Misses      43815    43825      +10     
- Partials     6582     6583       +1
Impacted Files Coverage Δ
routers/web/org/org_labels.go 0.00% <0.00%> (ø)
modules/queue/queue_bytefifo.go 59.28% <0.00%> (-3.60%) ⬇️
modules/queue/workerpool.go 50.00% <0.00%> (-3.06%) ⬇️
modules/process/manager.go 81.39% <0.00%> (-1.56%) ⬇️
models/issue_comment.go 52.40% <0.00%> (-0.29%) ⬇️
services/pull/pull.go 42.10% <0.00%> (+0.40%) ⬆️
routers/web/repo/view.go 39.50% <0.00%> (+0.46%) ⬆️
models/unit/unit.go 43.83% <0.00%> (+2.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 626b107...e60c246. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 29, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 29, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 30, 2021
@6543 6543 changed the title Fix wrong redirect Fix wrong redirect on org labels Dec 30, 2021
@6543 6543 merged commit 67d7ad6 into go-gitea:main Dec 30, 2021
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 30, 2021
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
f8dd227 
* giteaoffical/main:
  Fix wrong redirect on org labels (go-gitea#18128)
  Fix performance regression when user has many organization (go-gitea#18125)
  docs: add various ways to install from package (go-gitea#18120)
  Removed unused method. (go-gitea#18129)
  [skip ci] Updated translations via Crowdin
  Removed unused endpoint. (go-gitea#18127)
lunny pushed a commit to lunny/gitea that referenced this pull request Dec 30, 2021
@KN4CK3R @lunny
Fix wrong redirect on org labels (go-gitea#18128)
4852ebf
@lunny lunny mentioned this pull request Dec 30, 2021
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Dec 30, 2021
6543 pushed a commit that referenced this pull request Dec 30, 2021
@lunny @KN4CK3R
Fix wrong redirect on org labels (#18128) (#18134)
7e08434 
* Fix wrong redirect on org labels (#18128)

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@KN4CK3R KN4CK3R deleted the fix-labels-link branch January 5, 2022 21:16
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@KN4CK3R
Fix wrong redirect on org labels (go-gitea#18128)
57a49f3
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@noerw noerw noerw approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
8 participants
@KN4CK3R @codecov-commenter @lunny @techknowlogick @wxiaoguang @noerw @6543 @GiteaBot