Commit status indicator is not clickable on Pull Requests page #18810
Labels
topic/ui
Change the appearance of the Gitea UI
type/enhancement
An improvement of existing functionality
Milestone
Comments
noerw
added
type/enhancement
zeripath
pushed a commit
that referenced
this issue
Apr 26, 2022
This gets the necessary data to the issuelist for it to support a clickable commit status icon which pops up the full list of commit statuses related to the commit. It accomplishes this without any additional queries or fetching as the existing codepath was already doing the necessary work but only returning the "last" status. All methods were wrapped to call the least-filtered version of each function in order to maximize code reuse. Note that I originally left `getLastCommitStatus()` in `pull.go` which called to the new function, but `make lint` complained that it was unused, so I removed it. I would have preferred to keep it, but alas. The only thing I'd still like to do here is force these popups to happen to the right by default instead of the left. I see that the only other place this is popping up right is on view_list.tmpl, but I can't figure out how/why right now. Fixes #18810
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this issue
Aug 24, 2022
This gets the necessary data to the issuelist for it to support a clickable commit status icon which pops up the full list of commit statuses related to the commit. It accomplishes this without any additional queries or fetching as the existing codepath was already doing the necessary work but only returning the "last" status. All methods were wrapped to call the least-filtered version of each function in order to maximize code reuse. Note that I originally left `getLastCommitStatus()` in `pull.go` which called to the new function, but `make lint` complained that it was unused, so I removed it. I would have preferred to keep it, but alas. The only thing I'd still like to do here is force these popups to happen to the right by default instead of the left. I see that the only other place this is popping up right is on view_list.tmpl, but I can't figure out how/why right now. Fixes go-gitea#18810
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Gitea Version
1.16.1, try.gitea.io 1.17.0+dev-183-g41aa49d91
Operating System
Ubuntu 20.04.3, aarch64/arm64
Browser Version
Google Chrome Version 98.0.4758.102 (Official Build) (64-bit)
Can you reproduce the bug on the Gitea demo site?
Yes
Description
The ✔️ / ❌ icons next to PRs with commit statuses recorded are not clickable to show the list of commit statuses and their links, but they are clickable everywhere else they show up. I don't remember if these were clickable in 1.15.x, but I feel like they were. Either way, they probably should be.
Visible at: https://try.gitea.io/parnic-sks/commit-status-test/pulls
I would expect it to show up like it does in other places, e.g.: https://try.gitea.io/parnic-sks/commit-status-test/pulls/1
Repro:
Screenshots
Not clickable:
Expect to be able to see the flyout like when clicking the icon in other places:
The text was updated successfully, but these errors were encountered: