Fix panic in teams API when requesting members #19360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is dead, that's the reason why the build fails. |
GiteaBot
added
the
lgtm/need 2
Gusted
approved these changes
Apr 9, 2022
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Apr 9, 2022
GiteaBot
added
lgtm/done
lunny
requested changes
Apr 9, 2022
lunny
reviewed
Apr 9, 2022
|
I mean, what's the benefit? |
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
lunny
approved these changes
Apr 9, 2022
Both should work, but you should only chose one. You can't chose both, otherwise the slice will have 2 times elements and the first part are empty elements. |
wxiaoguang
approved these changes
Apr 11, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 12, 2022
* giteaoffical/main: Document 409 error returned by repos/migrate api (go-gitea#19376) Fix middleware function's placements for some `/user/...` (go-gitea#19377) Fix panic in teams API when requesting members (go-gitea#19360)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
Should fix #19359
Do we backport API errors?Unnecessary in this case, error does not exist yet on v1.16 branch.
If I had to guess, one of the many
move xxx from models/ to models/xxx/refactorings were the cause of this bug.