node12 is EOL

[techknowlogick]

https://endoflife.date/nodejs

[silverwind]

I would revert because there is no necessity to require v14 and some OS are still shipping very old Node versions. For example, Ubuntu 22.04 ships with the v12 branch, they probably won't update to new major versions during the lifetime of that version. Also, the update missed updating version in at least in README, Makefile.

[wxiaoguang]

IMO this PR is correct (or, at least, not wrong)

Also, the update missed updating version in at least in README, Makefile.

It doesn't miss anything, instead, it just makes everything correct (and up-to-dated).

For example, in README, it already say that Gitea requires "Node.js LTS" and the link points to Node.js 16 LTS.

For Makefile, it just checks package.json

And for package.json, it already declared "node": ">= 14"

I don't know what's the necessary to keep using an outdated nodejs shipped with OS. For example, Debian 11 (stable) only has Golang 1.15, do you want to make the code can be compiled with Go 1.15?

[silverwind]

For example, in README, it already say that Gitea requires "Node.js LTS" and the link points to Node.js 16 LTS.
For Makefile, it just checks package.json

Right, I forgot we had it that way already.

I don't know what's the necessary to keep using an outdated nodejs. For example, Debian 11 (stable) only has Golang 1.15, do you want to make the code can be compiled with Go 1.15?

My point is we should declare our minimum supported version and that remains v12.17 or greater. There's no strict need for v14 now and v12 will still see a lot of usage even if unsupported because it comes in Ubuntu/Debian base repos. IIRC, the Ubuntu/Debian maintainers will still backport critical fixes into those "forked" versions so the remain "supported" in a sense, just not by Node.js team.