Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't panic on ErrEmailInvalid #19441

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Don't panic on ErrEmailInvalid #19441

merged 2 commits into from
Apr 20, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Apr 20, 2022

@Gusted
Don't panic on ErrEmailInvalid
46d7730 
- Don't panic on `ErrEmailInvalid`, this was caused due that we were
trying to force `ErrEmailCharIsNotSupported` interface, which panics.
- Resolves go-gitea#19397
@Gusted Gusted added this to the 1.17.0 milestone Apr 20, 2022
@Gusted Gusted added type/bug modifies/api This PR adds API routes or modifies them backport/v1.16 labels Apr 20, 2022
Gusted added a commit to Gusted/gitea that referenced this pull request Apr 20, 2022
@Gusted
Don't panic on ErrEmailInvalid (go-gitea#19441)
9854e8e 
- Backport go-gitea#19441
  - Don't panic on `ErrEmailInvalid`, this was caused due that we were trying to force `ErrEmailCharIsNotSupported` interface, which panics.
  - Resolves go-gitea#19397
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 20, 2022
@Gusted Gusted mentioned this pull request Apr 20, 2022
Merged
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2022
@6543 6543 added the backport/done All backports for this PR have been created label Apr 20, 2022
@6543
Copy link
Member

6543 commented Apr 20, 2022

-> #19442

@codecov-commenter
Copy link

Codecov Report

Merging #19441 (03bfc17) into main (1e319ba) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main   #19441      +/-   ##
==========================================
- Coverage   47.40%   47.40%   -0.01%     
==========================================
  Files         951      951              
  Lines      132327   132333       +6     
==========================================
+ Hits        62731    62733       +2     
- Misses      62045    62048       +3     
- Partials     7551     7552       +1
Impacted Files Coverage Δ
routers/api/v1/user/email.go 82.14% <66.66%> (+1.95%) ⬆️
modules/notification/mail/mail.go 39.04% <0.00%> (-2.74%) ⬇️
modules/log/event.go 59.92% <0.00%> (-2.34%) ⬇️
modules/notification/ui/ui.go 58.92% <0.00%> (-1.79%) ⬇️
models/notification.go 63.17% <0.00%> (-1.09%) ⬇️
models/repo_list.go 75.66% <0.00%> (-0.49%) ⬇️
models/issue_comment.go 51.69% <0.00%> (-0.23%) ⬇️
modules/queue/queue_bytefifo.go 50.18% <0.00%> (ø)
models/user/email_address.go 47.05% <0.00%> (+0.92%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e319ba...03bfc17. Read the comment docs.

@6543 6543 merged commit 23d3767 into go-gitea:main Apr 20, 2022
zeripath pushed a commit that referenced this pull request Apr 20, 2022
@Gusted @6543
Don't panic on ErrEmailInvalid (#19441) (#19442)
5863f7e 
- Backport #19441
  - Don't panic on `ErrEmailInvalid`, this was caused due that we were trying to force `ErrEmailCharIsNotSupported` interface, which panics.
  - Resolves #19397

Co-authored-by: 6543 <6543@obermui.de>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 21, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
c7272c6 
* giteaofficial/main:
  Fix logging of Transfer API (go-gitea#19456)
  RepoAssignment ensure to close before overwrite (go-gitea#19449)
  node12 is EOL (go-gitea#19451)
  Add Changelog v1.16.6 (go-gitea#19339) (go-gitea#19450)
  Fix DELETE request for non-existent public key (go-gitea#19443)
  [skip ci] Updated translations via Crowdin
  Don't panic on `ErrEmailInvalid` (go-gitea#19441)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@Gusted @AbdulrhmnGhanem
Don't panic on ErrEmailInvalid (go-gitea#19441)
2c81c3c 
- Don't panic on `ErrEmailInvalid`, this was caused due that we were
trying to force `ErrEmailCharIsNotSupported` interface, which panics.
- Resolves go-gitea#19397
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Internal Server error when doing a POST with invalid emails on /v1/user/emails
6 participants
@Gusted @6543 @codecov-commenter @techknowlogick @GiteaBot @zeripath