Only check for non-finished migrating task #19601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gusted
commented
May 3, 2022
Gusted
commented
- Only check if a non-finished migrating task exists for a mirror before fetching the mirror details from the database.
- Resolves 500 Internal Server Error when accessing settings for mirror #19600
- Regression: Don't fetch Mirror when it's migrating #19588
- Only check if a non-finished migrating task exists for a mirror before fetching the mirror details from the database. - Resolves go-gitea#19600 - Regression: go-gitea#19588
Gusted
added
issue/regression
delvh
approved these changes
May 4, 2022
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
May 4, 2022
GiteaBot
added
lgtm/done
delvh
requested changes
May 4, 2022
| // HasFinishedMigratingTask returns if a finished migration task exists for the repo. | ||
| func HasFinishedMigratingTask(repoID int64) (bool, error) { | ||
| return db.GetEngine(db.DefaultContext). | ||
| Where("repo_id=? AND type=? AND status=?", repoID, structs.TaskTypeMigrateRepo, structs.TaskStatusFinished). |
There was a problem hiding this comment.
Suggested change
| Where("repo_id=? AND type=? AND status=?", repoID, structs.TaskTypeMigrateRepo, structs.TaskStatusFinished). | |
| Where("repo_id=? AND type=? AND status<>?", repoID, structs.TaskTypeMigrateRepo, structs.TaskStatusRunning). |
There was a problem hiding this comment.
Or how should failed migrations be handled?
There was a problem hiding this comment.
Failed migrations don't have a any information in the Mirror table.
delvh
approved these changes
May 4, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 4, 2022
* giteaofficial/main: Add health check endpoint (go-gitea#18465) Only check for non-finished migrating task (go-gitea#19601) Make .cs highlighting legible on dark themes. (go-gitea#19604)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
* Only check for non-finished migrating task - Only check if a non-finished migrating task exists for a mirror before fetching the mirror details from the database. - Resolves go-gitea#19600 - Regression: go-gitea#19588 * Clarify function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.