Don't fetch Mirror when it's migrating #19588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gusted
commented
May 2, 2022
Gusted
commented
- When a repository is still being migrated, don't try to fetch the Mirror from the database. Instead skip it. This allows to visit repositories that are still being migrated and were configured to be mirrored.
- Resolves HTTP 500 on new migration. #19585
- Regression: A pull-mirror repo should be marked as such on creation #19295
- When a repository is still being migrated, don't try to fetch the Mirror from the database. Instead skip it. This allows to visit repositories that are still being migrated and were configured to be mirrored. - Resolves go-gitea#19585 - Regression: go-gitea#19295
Gusted
added
type/bug
issue/regression
Codecov Report
@@ Coverage Diff @@
## main #19588 +/- ##
=======================================
Coverage ? 47.38%
=======================================
Files ? 952
Lines ? 132673
Branches ? 0
=======================================
Hits ? 62869
Misses ? 62222
Partials ? 7582
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
May 3, 2022
GiteaBot
added
lgtm/need 1
a1012112796
approved these changes
May 3, 2022
GiteaBot
added
lgtm/done
lafriks
approved these changes
May 3, 2022
Gusted
added a commit
to Gusted/gitea
that referenced
this pull request
May 3, 2022
- Only check if a non-finished migrating task exists for a mirror before fetching the mirror details from the database. - Resolves go-gitea#19600 - Regression: go-gitea#19588
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 4, 2022
* giteaofficial/main: Fix broken TR on cherrypick page (go-gitea#19599) Use correct context in `routers/web` (go-gitea#19597) Use for a repo action one database transaction (go-gitea#19576) Only set CanColorStdout / CanColorStderr to true if the stdout/stderr is a terminal (go-gitea#19581) Don't fetch Mirror when it's migrating (go-gitea#19588) Move user password verification after checking his groups on ldap auth (go-gitea#19587)
6543
pushed a commit
that referenced
this pull request
May 4, 2022
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
- When a repository is still being migrated, don't try to fetch the Mirror from the database. Instead skip it. This allows to visit repositories that are still being migrated and were configured to be mirrored. - Resolves go-gitea#19585 - Regression: go-gitea#19295 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
* Only check for non-finished migrating task - Only check if a non-finished migrating task exists for a mirror before fetching the mirror details from the database. - Resolves go-gitea#19600 - Regression: go-gitea#19588 * Clarify function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.