Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page to show diff between 2 git refs #19862

Closed
XonqNopp opened this issue Jun 1, 2022 · 2 comments
Closed

Page to show diff between 2 git refs #19862

XonqNopp opened this issue Jun 1, 2022 · 2 comments
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@XonqNopp
Copy link

XonqNopp commented Jun 1, 2022

Feature Description

I think it would be helpful to have a web page to show the difference between 2 git refs. I think (but I clearly do not know your source code so maybe I am wrong) that it could be like "extracted" from the page of the PR diff, and would then accept 2 git refs (commit hash, branch name, tag...).

Then in the PR, it could be used with the branch names to work as it is today.

Where it gets interesting, is that when there is a new push/force-push in a PR, the comment saying "pushed from 123 to abc" could feature a link to the diff web page with the old and new commit. So users could easily see what changed compared to the previous status. If the review was already done and only minor fixes were applied, it helps save some time.

I tried to browse the issues mentioning diff but I am still not sure, maybe this is some kind of duplicate of #13416 or #12800 Sorry if so...

cc @99rgosse

Screenshots

No response

@XonqNopp XonqNopp added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Jun 1, 2022
@FWDekker
Copy link
Contributor

You can compare two refs using the URL <owner>/<repo>/compare/<ref1>..<ref2>, for example https://try.gitea.io/florine/test/compare/1d9ce8b661edd20afa1697d793da8117e5c32dfa..8b135d6f3ed9cc359b2b307df49fe89e4d9f3515. This also works with branches and tags instead of commits.

Also, with force pushes, there is a "compare" button to the right of the message:
Screenshot of the Gitea interface with the "compare" button on the right.

See for example https://try.gitea.io/florine/test/pulls/1.

@XonqNopp
Copy link
Author

Yes now it is working. Thanks

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

2 participants