Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tree compare page for comparing two changesets/patchsets each consisting multiple commits. #12800

Open
ghost opened this issue Sep 10, 2020 · 0 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@ghost
Copy link

ghost commented Sep 10, 2020

The current diff page only shows how the content tracked by the repo changes between two commits.

Some people would like to do PR review not just reviewing the content of the change but also the fact of how it is structured into commits. To be able to track PR evolution it would be useful to see how the change is moving between commits for changesets/PR revisions. (The reason why some people want this is mostly that they have the philosophy that they are trying to keep a tidy/clean history. Also they are maybe trying to make "atomic changes" which are self contained enough to easily move between branches, by e.g.: cherry-picking )

How this should look like visually is an interesting question.

Basically you want to continue to see the change contained in the changesets but also there is an extra additional "dimension" about comparing how they are distributed between commits how they moved between commits. Also the number of commits can change, some or all could be squashed into one commit.

New additional changes between changesets (e.g.: revisions of a PR) could come in either as brand new separate commits or as part of a previously existing commit.

I am not aware of any system that have UI for something like this.

@ghost ghost mentioned this issue Sep 10, 2020
@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Sep 13, 2020
@ghost ghost mentioned this issue Oct 26, 2020
ghost pushed a commit to 05storm26/gitea that referenced this issue Oct 26, 2020
…o-gitea#12800

Also add warnings if a '/compare/base...head' is y shaped and offer to
show the raw difference (where the inverse of new commits on base are
included in the diff) and also offer to compare the y shaped junction
with range-diff.

The rangediff page uses the interdiff tool to work out the changes
between corresponding commits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant