Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move issues related files into models/issues #19931

Merged
merged 15 commits into from
Jun 13, 2022
Merged

Move issues related files into models/issues #19931

merged 15 commits into from
Jun 13, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 10, 2022 •
edited
Loading

depends on #19879

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jun 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@3708ca8). Click here to learn what that means.
The diff coverage is 47.30%.

@@           Coverage Diff           @@
##             main   #19931   +/-   ##
=======================================
  Coverage        ?   47.34%           
=======================================
  Files           ?      967           
  Lines           ?   134130           
  Branches        ?        0           
=======================================
  Hits            ?    63503           
  Misses          ?    62906           
  Partials        ?     7721
Impacted Files Coverage Δ
models/consistency.go 34.78% <ø> (ø)
models/db/consistency.go 0.00% <0.00%> (ø)
models/db/list_options.go 63.63% <ø> (ø)
models/error.go 38.66% <ø> (ø)
models/issues/assignees.go 68.57% <ø> (ø)
models/issues/issue_lock.go 0.00% <ø> (ø)
models/issues/issue_project.go 32.23% <ø> (ø)
models/issues/issue_watch.go 54.43% <0.00%> (ø)
models/issues/pull_list.go 64.17% <ø> (ø)
models/org_team.go 40.66% <0.00%> (ø)
... and 109 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3708ca8...68744d1. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 11, 2022
@lunny lunny requested review from 6543, zeripath and KN4CK3R and removed request for 6543, zeripath and KN4CK3R June 11, 2022 08:14
@Gusted Gusted added this to the 1.18.0 milestone Jun 12, 2022
@GiteaBot GiteaBot removed the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 13, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 13, 2022
@lunny lunny modified the milestones: 1.18.0, 1.17.0 Jun 13, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 13, 2022
@lunny lunny merged commit 1a9821f into go-gitea:main Jun 13, 2022
@lunny lunny deleted the lunny/model_issue branch June 13, 2022 09:38
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 13, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
1bdfd75 
* giteaofficial/main:
  Add deprecated log when using MySQL with utf8 charset (go-gitea#19952)
  Move issues related files into models/issues (go-gitea#19931)
  fix: some typos (go-gitea#19956)
  [skip ci] Updated translations via Crowdin
  Move some code into models/git (go-gitea#19879)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@lunny @AbdulrhmnGhanem
Move issues related files into models/issues (go-gitea#19931)
5c901d1 
* Move access and repo permission to models/perm/access

* fix test

* fix git test

* Move functions sequence

* Some improvements per @KN4CK3R and @delvh

* Move issues related code to models/issues

* Move some issues related sub package

* Merge

* Fix test

* Fix test

* Fix test

* Fix test

* Rename some files
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@6543 6543 6543 approved these changes

@zeripath zeripath Awaiting requested review from zeripath

@KN4CK3R KN4CK3R Awaiting requested review from KN4CK3R

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lunny @codecov-commenter @wxiaoguang @6543 @GiteaBot @Gusted