Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated log when using MySQL with utf8 charset #19952

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 13, 2022

So many issues caused by MySQL utf8 so I think we could drop the support for it.
This PR only adds an error log when using it.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 13, 2022
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seldom people would see this log.

Gitea could do the database version (maybe including some config) check when starting, and always show a warning on the UI for incompatible databases:

  1. MySQL without utf8mb4
  2. PostgreSQL <= 9.4 (or maybe some other version, not sure)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 13, 2022
@lunny
Copy link
Member Author

lunny commented Jun 13, 2022

make L-G-T-M work.

@lunny lunny merged commit 3c6c150 into go-gitea:main Jun 13, 2022
@lunny lunny deleted the lunny/deprecated_utf8_mysql branch June 13, 2022 12:55
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 13, 2022
* giteaofficial/main:
  Add deprecated log when using MySQL with utf8 charset (go-gitea#19952)
  Move issues related files into models/issues (go-gitea#19931)
  fix: some typos (go-gitea#19956)
  [skip ci] Updated translations via Crowdin
  Move some code into models/git (go-gitea#19879)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants