Add deprecated log when using MySQL with utf8 charset #19952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
approved these changes
Jun 13, 2022
GiteaBot
added
the
lgtm/need 1
wxiaoguang
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
Seldom people would see this log.
Gitea could do the database version (maybe including some config) check when starting, and always show a warning on the UI for incompatible databases:
- MySQL without utf8mb4
- PostgreSQL <= 9.4 (or maybe some other version, not sure)
GiteaBot
added
lgtm/done
|
make L-G-T-M work. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 13, 2022
* giteaofficial/main: Add deprecated log when using MySQL with utf8 charset (go-gitea#19952) Move issues related files into models/issues (go-gitea#19931) fix: some typos (go-gitea#19956) [skip ci] Updated translations via Crowdin Move some code into models/git (go-gitea#19879)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So many issues caused by MySQL utf8 so I think we could drop the support for it.
This PR only adds an error log when using it.