Fix dashboard switching on Mobile #20238
Conversation
- This is a regression of improving mobile experience on Gitea, currently organization dashboard aren't readable and the popup won't show up when you want to switch between users/organization(as we saw in - This patch fixes that, by allowing the popup to allocate the required pixels(for some absurd reason, z-index doesn't work on the popup, so it's not able to render over the existing elements, we can investigate later of why this is). And also remove the additional dropdown menu for the pages link, so it's one unified list which then can be displayed as rows.
Gusted
added
type/bug
skip-changelog
- Backport go-gitea#20238 - This is a regression of improving mobile experience on Gitea, currently organization dashboard aren't readable and the popup won't show up when you want to switch between users/organization(as we saw in go-gitea#19978). - This patch fixes that, by allowing the popup to allocate the required pixels(for some absurd reason, z-index doesn't work on the popup, so it's not able to render over the existing elements, we can investigate later of why this is). And also remove the additional dropdown menu for the pages link, so it's one unified list which then can be displayed as rows. - See original PR for screenshots.
GiteaBot
added
the
lgtm/need 2
|
Hmm... Interesting diff, you've removed the "right stackable menu" wrapping div from around the organisations action menu and then added an !important selector to stackable? These don't seem intimately related to fixing the context selector drop-down and your screenshots don't appear to be showing what happens to this action menu. |
If we don't have this change(requires to have that removed div to have the
Or we drop the |
|
Removed the for now unnecessary |
GiteaBot
removed
the
lgtm/need 2
GiteaBot
added
the
lgtm/need 1
|
I think we need to do a similar thing to the navbar trick but this is a definite improvement. There's an issue with @mediaMd spilling over now though. |
|
what's the current status ?!? |
|
Sorry @Gusted didn't realise you were waiting on me - Do you have an updated PR that you were thinking on showing me? |
Currently not. Because I don't have a clue how to proceed. I could see if tippy.js would work for the dropdowns and have a general fix. Or just fiddle around with CSS and HTML structures so the original colors won't be lost, as noted in your review. |
|
Ugh dropdown seems to be bit more complicated to make it compatible with tippy.js. So for now just dirty CSS to fix this issue. |
GiteaBot
added
lgtm/done
- This is a regression of improving mobile experience on Gitea, currently organization dashboard aren't readable and the popup won't show up when you want to switch between users/organization(as we saw in #19978). - This patch fixes that, by allowing the popup to allocate the required pixels(for some absurd reason, z-index doesn't work on the popup, so it's not able to render over the existing elements, we can investigate later of why this is). And also remove the additional dropdown menu for the pages link, so it's one unified list which then can be displayed as rows.
|
🪨 |
- This is a regression of improving mobile experience on Gitea, currently organization dashboard aren't readable and the popup won't show up when you want to switch between users/organization(as we saw in go-gitea#19978). - This patch fixes that, by allowing the popup to allocate the required pixels(for some absurd reason, z-index doesn't work on the popup, so it's not able to render over the existing elements, we can investigate later of why this is). And also remove the additional dropdown menu for the pages link, so it's one unified list which then can be displayed as rows.
Before
After