Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move part of modules/notification to services #20261

Closed
harryzcy opened this issue Jul 6, 2022 · 0 comments · Fixed by #26737
Closed

Move part of modules/notification to services #20261

harryzcy opened this issue Jul 6, 2022 · 0 comments · Fixed by #26737
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Comments

@harryzcy
Copy link
Contributor

harryzcy commented Jul 6, 2022

Feature Description

To avoid importing models into modules. The issue is raised here

Screenshots

No response
@harryzcy harryzcy added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Jul 6, 2022
@harryzcy harryzcy mentioned this issue Jul 6, 2022
Merged
2 tasks
@harryzcy harryzcy mentioned this issue Aug 26, 2023
Merged
@lunny lunny added type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Aug 26, 2023
lunny pushed a commit that referenced this issue Aug 27, 2023
@harryzcy
Move modules/mirror to services (#26737)
4365274 
To solve the cyclic imports in a better way

Closes #20261
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move modules/mirror to services harryzcy/gitea
2 participants
@lunny @harryzcy