Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix org members bug #20489

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Fix org members bug #20489

merged 4 commits into from
Jul 26, 2022

Conversation

nagos
Copy link
Contributor

@nagos nagos commented Jul 26, 2022

Fixed 500 error on organization members page.
Bug was introduced in d6779c7
Only non empy orgs are affected.

Expanded org unit test to cover this problem.

@nagos nagos changed the title Public org members bug Fux org members bug Jul 26, 2022
@nagos nagos changed the title Fux org members bug Fix org members bug Jul 26, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 26, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 26, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #20489 (567cc76) into main (a701fd3) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #20489      +/-   ##
==========================================
+ Coverage   46.91%   46.93%   +0.01%     
==========================================
  Files         977      977              
  Lines      135285   135285              
==========================================
+ Hits        63471    63490      +19     
+ Misses      64031    64011      -20     
- Partials     7783     7784       +1     
Impacted Files Coverage Δ
modules/queue/queue_bytefifo.go 47.29% <0.00%> (-5.78%) ⬇️
modules/queue/queue_disk.go 60.00% <0.00%> (-3.34%) ⬇️
modules/queue/workerpool.go 52.84% <0.00%> (-3.11%) ⬇️
routers/api/v1/repo/pull.go 47.17% <0.00%> (+0.17%) ⬆️
routers/web/auth/auth.go 26.76% <0.00%> (+0.50%) ⬆️
services/pull/pull.go 40.80% <0.00%> (+0.61%) ⬆️
services/pull/check.go 29.13% <0.00%> (+1.18%) ⬆️
modules/queue/queue_channel.go 80.55% <0.00%> (+1.85%) ⬆️
modules/context/org.go 53.45% <0.00%> (+2.51%) ⬆️
routers/web/org/members.go 30.69% <0.00%> (+30.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@jolheiser jolheiser merged commit 5ed082b into go-gitea:main Jul 26, 2022
@6543 6543 added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed backport/v1.17 labels Jul 26, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 27, 2022
* giteaofficial/main:
  Hide internal package versions (go-gitea#20492)
  Fix org members bug (go-gitea#20489)
  Add labels to two buttons that were missing them (go-gitea#20419)
  fix enabling repo packages when projects are off (go-gitea#20486)
  Display project in issue list (go-gitea#20434)
  Make code review ceckboxes clickable (go-gitea#20481)
  Slightly simplify LastCommitCache (go-gitea#20444)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
* Fix bug in public only org members list

bug was introduced in d6779c7

* Expanded org unit test
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants