Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distorted PR changes UI with german localization #20922

Closed
otbutz opened this issue Aug 23, 2022 · 3 comments · Fixed by #20934
Closed

Distorted PR changes UI with german localization #20922

otbutz opened this issue Aug 23, 2022 · 3 comments · Fixed by #20934
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@otbutz
Copy link

otbutz commented Aug 23, 2022

Description

After an update from 1.16.x to 1.17.1, the menu of the PR changes page is distorted with German localization. Hitting Ctrl+F5 doesn't change anything. The UI looks normal if i switch to English.

Gitea Version

1.17.1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

German:

image

English:

image

Git Version

No response

Operating System

No response

How are you running Gitea?

Downloaded from the release page, running as a service via systemd

Database

PostgreSQL
@silverwind
Copy link
Member

silverwind commented Aug 23, 2022 •
edited
Loading

Probably need to make more space by changing buttons to icon-only to make space for longer translations.

@silverwind silverwind added the topic/ui Change the appearance of the Gitea UI label Aug 23, 2022
@otbutz
Copy link
Author

otbutz commented Aug 23, 2022

Maybe related to the changes introduced in #19546 ?

@silverwind silverwind mentioned this issue Aug 23, 2022
Merged
silverwind added a commit to silverwind/gitea that referenced this issue Aug 23, 2022
@silverwind
Change review buttons to icons to make space for text
f6303f2 
The layout on the review code view was broken depending on length of the
text before. Change all three buttons to icons with tooltip to make more
space for these long texts.

Fixes: go-gitea#20922
@silverwind
Copy link
Member

Not sure, but #20934 will fix it.

6543 pushed a commit that referenced this issue Aug 26, 2022
@silverwind
Change review buttons to icons to make space for text (#20934)
94549bc 
The layout on the review code view was broken depending on length of the text. Change all three buttons to icons with tooltip to make more space for these long texts.

Fixes: #20922
silverwind added a commit to silverwind/gitea that referenced this issue Aug 27, 2022
@silverwind
Change review buttons to icons to make space for text (go-gitea#20934)
1b2db43 
The layout on the review code view was broken depending on length of the text. Change all three buttons to icons with tooltip to make more space for these long texts.

Fixes: go-gitea#20922
@silverwind silverwind mentioned this issue Aug 27, 2022
Merged
lafriks pushed a commit that referenced this issue Aug 27, 2022
@silverwind
Change review buttons to icons to make space for text (#20934) (#20978)
0a0cd75 
The layout on the review code view was broken depending on length of the text. Change all three buttons to icons with tooltip to make more space for these long texts.

Fixes: #20922
vsysoev pushed a commit to IntegraSDL/gitea that referenced this issue Aug 28, 2022
@silverwind
Change review buttons to icons to make space for text (go-gitea#20934)
8a564ce 
The layout on the review code view was broken depending on length of the text. Change all three buttons to icons with tooltip to make more space for these long texts.

Fixes: go-gitea#20922
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change review buttons to icons to make space for text silverwind/gitea
2 participants
@silverwind @otbutz