Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone statistics not being recalculated on issue delete #21254

Closed
stuzer05 opened this issue Sep 24, 2022 · 0 comments · Fixed by #21459
Closed

Milestone statistics not being recalculated on issue delete #21254

stuzer05 opened this issue Sep 24, 2022 · 0 comments · Fixed by #21459
Labels
Milestone

Comments

@stuzer05
Copy link

Description

When you delete issues from milestone, milestone's "completed" and "# closed issues" field not being recalculated.

To replicate this issue:

  1. create a milestone
  2. create any number of issues
  3. close any number of issues
  4. delete closed issue
  5. Milestone's statistics will be broken

Gitea Version

1.18.0+dev-450-g10228387d

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

image
image

Git Version

No response

Operating System

No response

How are you running Gitea?

gitea's demo site

Database

No response

@lunny lunny added this to the 1.17.4 milestone Oct 17, 2022
lunny added a commit that referenced this issue Oct 22, 2022
When actions besides "delete" are performed on issues, the milestone
counter is updated. However, since deleting issues goes through a
different code path, the associated milestone's count wasn't being
updated, resulting in inaccurate counts until another issue in the same
milestone had a non-delete action performed on it.

I verified this change fixes the inaccurate counts using a local docker
build.

Fixes #21254

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants