NuGet: Order of pushing packages breaks version grouping #21434

fitithw · 2022-10-13T08:35:07Z

Description

Very weird bug, no idea what causes it besides the push order, package names don't matter, nor the push times.
You can skip steps 2-5 if you just want to see the bugged version.

Create the packages:

$API_KEY="xxx"
$OWNER="xxx"
$GITEA_HOST="https://try.gitea.io"
$SOURCE="$GITEA_HOST/api/packages/$OWNER/nuget/index.json"
$HEADERS=@{Authorization = "bearer $API_KEY"}

dotnet new classlib -n TestGiteaNuGet
msbuild .\TestGiteaNuGet\TestGiteaNuGet.csproj /t:pack /p:version=1.0.1 /p:includesymbols=true /p:symbolpackageformat=snupkg
msbuild .\TestGiteaNuGet\TestGiteaNuGet.csproj /t:pack /p:version=1.0.2 /p:includesymbols=true /p:symbolpackageformat=snupkg
msbuild .\TestGiteaNuGet\TestGiteaNuGet.csproj /t:pack /p:version=1.0.3 /p:includesymbols=true /p:symbolpackageformat=snupkg

dotnet new classlib -n TestGiteaNuGet.UI
msbuild .\TestGiteaNuGet.UI\TestGiteaNuGet.UI.csproj /t:pack /p:version=1.0.1 /p:includesymbols=true /p:symbolpackageformat=snupkg
msbuild .\TestGiteaNuGet.UI\TestGiteaNuGet.UI.csproj /t:pack /p:version=1.0.2 /p:includesymbols=true /p:symbolpackageformat=snupkg
msbuild .\TestGiteaNuGet.UI\TestGiteaNuGet.UI.csproj /t:pack /p:version=1.0.3 /p:includesymbols=true /p:symbolpackageformat=snupkg

Push the packages in order of package name and query the package server:

dotnet nuget push --source $SOURCE .\TestGiteaNuGet\bin\Debug\TestGiteaNuGet.1.0.1.nupkg --api-key $API_KEY
dotnet nuget push --source $SOURCE .\TestGiteaNuGet\bin\Debug\TestGiteaNuGet.1.0.2.nupkg --api-key $API_KEY
dotnet nuget push --source $SOURCE .\TestGiteaNuGet\bin\Debug\TestGiteaNuGet.1.0.3.nupkg --api-key $API_KEY
dotnet nuget push --source $SOURCE .\TestGiteaNuGet.UI\bin\Debug\TestGiteaNuGet.UI.1.0.1.nupkg --api-key $API_KEY
dotnet nuget push --source $SOURCE .\TestGiteaNuGet.UI\bin\Debug\TestGiteaNuGet.UI.1.0.2.nupkg --api-key $API_KEY
dotnet nuget push --source $SOURCE .\TestGiteaNuGet.UI\bin\Debug\TestGiteaNuGet.UI.1.0.3.nupkg --api-key $API_KEY

(Invoke-WebRequest -Uri $GITEA_HOST/api/packages/$OWNER/nuget/query?q=TestGiteaNuGet -Headers $HEADERS).Content

The results of NuGet query are correct:

{
    "totalHits": 6,
    "data": [
        {
            "id": "TestGiteaNuGet.UI",
            "version": "1.0.3",
            "versions": [
                {
                    "@id": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet.UI/1.0.3.json",
                    "version": "1.0.3",
                    "downloads": 0
                },
                {
                    "@id": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet.UI/1.0.2.json",
                    "version": "1.0.2",
                    "downloads": 0
                },
                {
                    "@id": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet.UI/1.0.1.json",
                    "version": "1.0.1",
                    "downloads": 0
                }
            ],
            "description": "Package Description",
            "authors": "TestGiteaNuGet.UI",
            "projectURL": "",
            "registration": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet.UI/index.json"
        },
        {
            "id": "TestGiteaNuGet",
            "version": "1.0.3",
            "versions": [
                {
                    "@id": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet/1.0.3.json",
                    "version": "1.0.3",
                    "downloads": 0
                },
                {
                    "@id": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet/1.0.2.json",
                    "version": "1.0.2",
                    "downloads": 0
                },
                {
                    "@id": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet/1.0.1.json",
                    "version": "1.0.1",
                    "downloads": 0
                }
            ],
            "description": "Package Description",
            "authors": "TestGiteaNuGet",
            "projectURL": "",
            "registration": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet/index.json"
        }
    ]
}

Now delete the packages from Gitea, either through UI or API:

Invoke-WebRequest -Uri $GITEA_HOST/api/v1/packages/$OWNER/nuget/testgiteanuget.ui/1.0.3 -Method DELETE -Headers $HEADERS
Invoke-WebRequest -Uri $GITEA_HOST/api/v1/packages/$OWNER/nuget/testgiteanuget.ui/1.0.2 -Method DELETE -Headers $HEADERS
Invoke-WebRequest -Uri $GITEA_HOST/api/v1/packages/$OWNER/nuget/testgiteanuget.ui/1.0.1 -Method DELETE -Headers $HEADERS
Invoke-WebRequest -Uri $GITEA_HOST/api/v1/packages/$OWNER/nuget/testgiteanuget/1.0.3 -Method DELETE -Headers $HEADERS
Invoke-WebRequest -Uri $GITEA_HOST/api/v1/packages/$OWNER/nuget/testgiteanuget/1.0.2 -Method DELETE -Headers $HEADERS
Invoke-WebRequest -Uri $GITEA_HOST/api/v1/packages/$OWNER/nuget/testgiteanuget/1.0.1 -Method DELETE -Headers $HEADERS

Optional (local instance): clear the package SQL table as the methods above do not, just to be sure (it works either way):

delete from package where lower_name in ('testgiteanuget', 'testgiteanuget.ui')

Push the packages in order of package version and query the package server:

dotnet nuget push --source $SOURCE .\TestGiteaNuGet\bin\Debug\TestGiteaNuGet.1.0.1.nupkg --api-key $API_KEY
dotnet nuget push --source $SOURCE .\TestGiteaNuGet.UI\bin\Debug\TestGiteaNuGet.UI.1.0.1.nupkg --api-key $API_KEY
dotnet nuget push --source $SOURCE .\TestGiteaNuGet\bin\Debug\TestGiteaNuGet.1.0.2.nupkg --api-key $API_KEY
dotnet nuget push --source $SOURCE .\TestGiteaNuGet.UI\bin\Debug\TestGiteaNuGet.UI.1.0.2.nupkg --api-key $API_KEY
dotnet nuget push --source $SOURCE .\TestGiteaNuGet\bin\Debug\TestGiteaNuGet.1.0.3.nupkg --api-key $API_KEY
dotnet nuget push --source $SOURCE .\TestGiteaNuGet.UI\bin\Debug\TestGiteaNuGet.UI.1.0.3.nupkg --api-key $API_KEY

(Invoke-WebRequest -Uri $GITEA_HOST/api/packages/$OWNER/nuget/query?q=TestGiteaNuGet -Headers $HEADERS).Content

The results of NuGet query are incorrect, every version is an individual package:

{
    "totalHits": 6,
    "data": [
        {
            "id": "TestGiteaNuGet.UI",
            "version": "1.0.3",
            "versions": [
                {
                    "@id": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet.UI/1.0.3.json",
                    "version": "1.0.3",
                    "downloads": 0
                }
            ],
            "description": "Package Description",
            "authors": "TestGiteaNuGet.UI",
            "projectURL": "",
            "registration": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet.UI/index.json"
        },
        {
            "id": "TestGiteaNuGet",
            "version": "1.0.3",
            "versions": [
                {
                    "@id": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet/1.0.3.json",
                    "version": "1.0.3",
                    "downloads": 0
                }
            ],
            "description": "Package Description",
            "authors": "TestGiteaNuGet",
            "projectURL": "",
            "registration": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet/index.json"
        },
        {
            "id": "TestGiteaNuGet.UI",
            "version": "1.0.2",
            "versions": [
                {
                    "@id": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet.UI/1.0.2.json",
                    "version": "1.0.2",
                    "downloads": 0
                }
            ],
            "description": "Package Description",
            "authors": "TestGiteaNuGet.UI",
            "projectURL": "",
            "registration": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet.UI/index.json"
        },
        {
            "id": "TestGiteaNuGet",
            "version": "1.0.2",
            "versions": [
                {
                    "@id": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet/1.0.2.json",
                    "version": "1.0.2",
                    "downloads": 0
                }
            ],
            "description": "Package Description",
            "authors": "TestGiteaNuGet",
            "projectURL": "",
            "registration": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet/index.json"
        },
        {
            "id": "TestGiteaNuGet.UI",
            "version": "1.0.1",
            "versions": [
                {
                    "@id": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet.UI/1.0.1.json",
                    "version": "1.0.1",
                    "downloads": 0
                }
            ],
            "description": "Package Description",
            "authors": "TestGiteaNuGet.UI",
            "projectURL": "",
            "registration": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet.UI/index.json"
        },
        {
            "id": "TestGiteaNuGet",
            "version": "1.0.1",
            "versions": [
                {
                    "@id": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet/1.0.1.json",
                    "version": "1.0.1",
                    "downloads": 0
                }
            ],
            "description": "Package Description",
            "authors": "TestGiteaNuGet",
            "projectURL": "",
            "registration": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet/index.json"
        }
    ]
}

Here's how it looks on Visual Studio 2022 Package Manager:

Now let's delete one of the packages and see if it "fixed" the other one:

Invoke-WebRequest -Uri $GITEA_HOST/api/v1/packages/$OWNER/nuget/testgiteanuget.ui/1.0.3 -Method DELETE -Headers $HEADERS
Invoke-WebRequest -Uri $GITEA_HOST/api/v1/packages/$OWNER/nuget/testgiteanuget.ui/1.0.2 -Method DELETE -Headers $HEADERS
Invoke-WebRequest -Uri $GITEA_HOST/api/v1/packages/$OWNER/nuget/testgiteanuget.ui/1.0.1 -Method DELETE -Headers $HEADERS

(Invoke-WebRequest -Uri $GITEA_HOST/api/packages/$OWNER/nuget/query?q=TestGiteaNuGet -Headers $HEADERS).Content

The other one is back to normal:

{
    "totalHits": 3,
    "data": [
        {
            "id": "TestGiteaNuGet",
            "version": "1.0.3",
            "versions": [
                {
                    "@id": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet/1.0.3.json",
                    "version": "1.0.3",
                    "downloads": 0
                },
                {
                    "@id": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet/1.0.2.json",
                    "version": "1.0.2",
                    "downloads": 0
                },
                {
                    "@id": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet/1.0.1.json",
                    "version": "1.0.1",
                    "downloads": 0
                }
            ],
            "description": "Package Description",
            "authors": "TestGiteaNuGet",
            "projectURL": "",
            "registration": "https://try.gitea.io/api/packages/fitithw/nuget/registration/TestGiteaNuGet/index.json"
        }
    ]
}

Gitea Version

1.17.2

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Windows Server 2019 Standard

How are you running Gitea?

Windows service from downloaded exe, but the bug can be reproduced on try.gitea.io.

Database

MSSQL

The text was updated successfully, but these errors were encountered:

KN4CK3R · 2022-10-13T15:14:11Z

~~Could you please dump the package and package_version tables for me when receiving the wrong result?~~

Found the error, will fix it soon.

KN4CK3R · 2022-10-13T15:51:56Z

Added a fix in #21442. Thank you for the detailed analysis 👍

Fixes #21434 Added tests to enforce this behaviour. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

Fixes go-gitea#21434 Added tests to enforce this behaviour. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

fitithw added the type/bug label Oct 13, 2022

KN4CK3R mentioned this issue Oct 13, 2022

Enforce grouped NuGet search results #21442

Merged

KN4CK3R added the topic/packages label Oct 13, 2022

wxiaoguang closed this as completed in #21442 Oct 16, 2022

wxiaoguang added a commit that referenced this issue Oct 16, 2022

Enforce grouped NuGet search results (#21442)

11d3677

Fixes #21434 Added tests to enforce this behaviour. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

go-gitea locked and limited conversation to collaborators May 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NuGet: Order of pushing packages breaks version grouping #21434

NuGet: Order of pushing packages breaks version grouping #21434

fitithw commented Oct 13, 2022

KN4CK3R commented Oct 13, 2022 •

edited

Loading

KN4CK3R commented Oct 13, 2022

NuGet: Order of pushing packages breaks version grouping #21434

NuGet: Order of pushing packages breaks version grouping #21434

Comments

fitithw commented Oct 13, 2022

Description

Gitea Version

Can you reproduce the bug on the Gitea demo site?

Log Gist

Screenshots

Git Version

Operating System

How are you running Gitea?

Database

KN4CK3R commented Oct 13, 2022 • edited Loading

KN4CK3R commented Oct 13, 2022

KN4CK3R commented Oct 13, 2022 •

edited

Loading