NPM Package Registry Returns 404 with upstream package-lock.json #21567
Labels
Comments
lunny
added a commit
that referenced
this issue
Oct 24, 2022
This PR fixes issue #21567 allowing for package tarball URLs to match the upstream registry (and GitLab/JFrog Artifactory URLs). It uses a regex to parse the filename (which contains the NPM version) and does a fuzzy search to pull it out. The regex was built/expanded from http://json.schemastore.org/package, https://github.com/Masterminds/semver, and https://docs.npmjs.com/cli/v6/using-npm/semver and is testable here: https://regex101.com/r/OydBJq/5 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Racer159
added a commit
to Racer159/gitea
that referenced
this issue
Nov 8, 2022
…tea#21568) Backport (go-gitea#21568) This PR fixes issue go-gitea#21567 allowing for package tarball URLs to match the upstream registry (and GitLab/JFrog Artifactory URLs). It uses a regex to parse the filename (which contains the NPM version) and does a fuzzy search to pull it out. The regex was built/expanded from http://json.schemastore.org/package, https://github.com/Masterminds/semver, and https://docs.npmjs.com/cli/v6/using-npm/semver and is testable here: https://regex101.com/r/OydBJq/5 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
lunny
added a commit
that referenced
this issue
Nov 9, 2022
… (#21723) Backport (#21568) This PR fixes issue #21567 allowing for package tarball URLs to match the upstream registry (and GitLab/JFrog Artifactory URLs). It uses a regex to parse the filename (which contains the NPM version) and does a fuzzy search to pull it out. The regex was built/expanded from http://json.schemastore.org/package, https://github.com/Masterminds/semver, and https://docs.npmjs.com/cli/v6/using-npm/semver and is testable here: https://regex101.com/r/OydBJq/5 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The NPM package registry adds a
/versionin the URL that it uses to pull down the package tarball from the remote, and while this works when a repository has been configured to use Gitea alone, migrating projects back and forth from another registry (i.e. https://registry.npmjs.org/) requires you to delete (or otherwise update) the package-lock.json file for npm to resolve the package correctly.Gitea Version
dcd9fc7
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
https://gist.github.com/Racer159/1f6a7d5ea64e76d0acc44c0b23606a3a
Screenshots
Git Version
2.38.0
Operating System
popOS 22.04
How are you running Gitea?
For this testing I was running it locally from a fresh copy built from
main. Normally, however this server is ran inside of Kubernetes with the official Gitea chart (specifically https://dl.gitea.io/charts version: 6.0.1).Database
SQLite
The text was updated successfully, but these errors were encountered: