Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add changelog for 1.18.0-rc1 #21829

Merged
merged 13 commits into from
Nov 24, 2022
Merged

add changelog for 1.18.0-rc1 #21829

merged 13 commits into from
Nov 24, 2022

Conversation

techknowlogick
Copy link
Member

No description provided.

@techknowlogick techknowlogick added outdated/backport/v1.18 This PR should be backported to Gitea 1.18 type/changelog Adds the changelog for a new Gitea version labels Nov 16, 2022
@techknowlogick techknowlogick added this to the 1.18.0 milestone Nov 16, 2022
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 16, 2022
@yardenshoham
Copy link
Member

Missing #21410?

techknowlogick
techknowlogick commented Nov 17, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@techknowlogick
Copy link
Member Author

Thanks @yardenshoham I've just added that.

lafriks
lafriks reviewed Nov 17, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
techknowlogick
techknowlogick commented Nov 17, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
techknowlogick
techknowlogick commented Nov 17, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@yardenshoham
Copy link
Member

yardenshoham commented Nov 18, 2022 •
edited

Missing?:

@Rainson12
Copy link

its about a month ago that RC.0 was released, given that its out now quite a while compared to previous released, is it not possible to make it 1.18 stable and if not, what is missing to make it a stable release?

@lunny
Copy link
Member

lunny commented Nov 23, 2022

All bug fixes has been backport to v1.17 or the bug affected by a feature which introduced in the same release should be ignored.

@lunny
Copy link
Member

lunny commented Nov 23, 2022

Really. Because those PRs are not correctly labeled. I will add them back.

@lunny
Copy link
Member

lunny commented Nov 23, 2022

Missing?:

For #21554 which is a follow up of #21533, so we can ignore it in the changelog like other features. What do you think about that?

@yardenshoham
Copy link
Member

#21554 makes more sense for changelog than #21533

@lunny
Copy link
Member

lunny commented Nov 23, 2022

#21554 makes more sense for changelog than #21533

Done.

kdumontnu
kdumontnu approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@kdumontnu kdumontnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is a big release!

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 23, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 23, 2022
delvh
delvh reviewed Nov 23, 2022
View reviewed changes
CHANGELOG.md
* Fix init mail render logic (#20704)
* Use correct page size for link header pagination (#20546)
* Preserve unix socket file (#20499)
* Use tippy.js for context popup (#20393)
Copy link
Member

@delvh delvh Nov 23, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that a bug?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can find the comment on #20393 (comment) .

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md
* Allow specifying SECRET_KEY_URI, similar to INTERNAL_TOKEN_URI (#19663)
* Implement sync push mirror on commit (#19411)
* Rework mailer settings (#18982)
* Add option to purge users (#18064)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is rather a feature as it is pretty important for server admins

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd admit it's very important but this will add a new option in the old options. It's not a new function. I'm OK to put it in enhancement.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@lunny
Copy link
Member

lunny commented Nov 24, 2022

make L-G-T-M work

@lunny lunny merged commit 9bccc60 into go-gitea:release/v1.18 Nov 24, 2022
@yardenshoham
Copy link
Member

Important! #20153 is breaking, very breaking!

@techknowlogick techknowlogick deleted the 1.18rc1 branch November 24, 2022 14:54
@jolheiser
Copy link
Member

Important! #20153 is breaking, very breaking!

Strange, it's labeled breaking, not sure why it wasn't put in the right section.

@jolheiser jolheiser removed the outdated/backport/v1.18 This PR should be backported to Gitea 1.18 label Jan 13, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks left review comments

@delvh delvh delvh left review comments

@kdumontnu kdumontnu kdumontnu approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/changelog Adds the changelog for a new Gitea version
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@techknowlogick @yardenshoham @Rainson12 @lunny @jolheiser @lafriks @kdumontnu @delvh @GiteaBot