-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add changelog for 1.18.0-rc1 #21829
add changelog for 1.18.0-rc1 #21829
Conversation
Missing #21410? |
Thanks @yardenshoham I've just added that. |
Missing?:
|
its about a month ago that RC.0 was released, given that its out now quite a while compared to previous released, is it not possible to make it 1.18 stable and if not, what is missing to make it a stable release? |
All bug fixes has been backport to v1.17 or the bug affected by a feature which introduced in the same release should be ignored. |
Really. Because those PRs are not correctly labeled. I will add them back. |
For #21554 which is a follow up of #21533, so we can ignore it in the changelog like other features. What do you think about that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is a big release!
* Fix init mail render logic (#20704) | ||
* Use correct page size for link header pagination (#20546) | ||
* Preserve unix socket file (#20499) | ||
* Use tippy.js for context popup (#20393) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is that a bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can find the comment on #20393 (comment) .
* Allow specifying SECRET_KEY_URI, similar to INTERNAL_TOKEN_URI (#19663) | ||
* Implement sync push mirror on commit (#19411) | ||
* Rework mailer settings (#18982) | ||
* Add option to purge users (#18064) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is rather a feature as it is pretty important for server admins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd admit it's very important but this will add a new option in the old options. It's not a new function. I'm OK to put it in enhancement.
make L-G-T-M work |
Important! #20153 is breaking, very breaking! |
Strange, it's labeled breaking, not sure why it wasn't put in the right section. |
No description provided.