Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit page "Actions" button label appears twice in mobile view #21973

Closed
markormesher opened this issue Nov 29, 2022 · 0 comments · Fixed by #21974
Closed

Commit page "Actions" button label appears twice in mobile view #21973

markormesher opened this issue Nov 29, 2022 · 0 comments · Fixed by #21974
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@markormesher
Copy link
Contributor

Description

On the commit view page the "Actions" button is labelled twice when viewed on a narrow-width device (anything that triggers the mobile-only CSS class).

Screenshots

before

Gitea Version

v1.17.3

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

No response

Browser Version

Chrome 107.0.5304.107
@markormesher markormesher added type/bug topic/ui Change the appearance of the Gitea UI labels Nov 29, 2022
@markormesher markormesher mentioned this issue Nov 29, 2022
Merged
techknowlogick pushed a commit that referenced this issue Dec 2, 2022
@markormesher @lunny
Remove duplicate "Actions" label in mobile view (#21974)
665d02e 
Closes #21973.

The "Actions" button on the commit view page is labelled twice in mobile
view. No other buttons on the page have a `mobile-only` extra label, so
this PR removes it.

Before:


![before](https://user-images.githubusercontent.com/6496999/204540002-75baa08a-6c06-4b39-847b-34272e09d71e.PNG)

After:


![after](https://user-images.githubusercontent.com/6496999/204539991-a0607765-d5e2-4b1a-84c9-a3e16cbc674e.PNG)

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
zeripath pushed a commit to zeripath/gitea that referenced this issue Jan 13, 2023
@markormesher @lunny @zeripath
Remove duplicate "Actions" label in mobile view (go-gitea#21974)
155c0ac 
Backport go-gitea#21974

Closes go-gitea#21973.

The "Actions" button on the commit view page is labelled twice in mobile
view. No other buttons on the page have a `mobile-only` extra label, so
this PR removes it.

Before:

![before](https://user-images.githubusercontent.com/6496999/204540002-75baa08a-6c06-4b39-847b-34272e09d71e.PNG)

After:

![after](https://user-images.githubusercontent.com/6496999/204539991-a0607765-d5e2-4b1a-84c9-a3e16cbc674e.PNG)

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@zeripath zeripath mentioned this issue Jan 13, 2023
Merged
zeripath added a commit that referenced this issue Jan 13, 2023
@zeripath @markormesher
@lunny @jolheiser
Remove duplicate "Actions" label in mobile view (#21974) (#22439)
f3034b1 
Backport #21974

Closes #21973.

The "Actions" button on the commit view page is labelled twice in mobile
view. No other buttons on the page have a `mobile-only` extra label, so
this PR removes it.

Before:


![before](https://user-images.githubusercontent.com/6496999/204540002-75baa08a-6c06-4b39-847b-34272e09d71e.PNG)

After:


![after](https://user-images.githubusercontent.com/6496999/204539991-a0607765-d5e2-4b1a-84c9-a3e16cbc674e.PNG)

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

Co-authored-by: Mark Ormesher <me@markormesher.co.uk>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicate "Actions" label in mobile view markormesher/gitea
1 participant
@markormesher