Fix heatmap first color being unused #22158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vue3-calendar-heatmap has the behaviour that the first and second colors are mapped to values null and 0, meaning the second color was not used as intended for values > 0. I think this is a behaviour change from previous vue2 version that was missed during the upgrade. This change makes first and second values the same, so the heatmap can now use one additional color for meaningful values.
zeripath
approved these changes
Dec 18, 2022
GiteaBot
added
the
lgtm/need 1
yardenshoham
approved these changes
Dec 18, 2022
GiteaBot
added
lgtm/done
delvh
reviewed
Dec 18, 2022
Comment on lines
+31
to
32
| 'var(--color-secondary-alpha-70)', | ||
| 'var(--color-secondary-alpha-70)', |
There was a problem hiding this comment.
We should probably mention why we do the same thing twice here…
There was a problem hiding this comment.
Don't really feel like littering the code too much with info that can be obtained by reading the module's docs:
The color at rangeColor[0] will always represent the values for a count: null
The color at rangeColor[1] will always represent the values for a count: 0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #22157. vue3-calendar-heatmap has the behaviour that the first and second colors are mapped to values null and 0, meaning the second color was not used as intended for values > 0. I think this is a behaviour change from previous vue2 version that was missed during the upgrade.
This change makes first and second values the same, so the heatmap can now use one additional color for meaningful values.