Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable timetracking: ENABLE_TIMETRACKING = false ? #22286

Closed
somera opened this issue Dec 30, 2022 · 0 comments · Fixed by #22374
Closed

Disable timetracking: ENABLE_TIMETRACKING = false ? #22286

somera opened this issue Dec 30, 2022 · 0 comments · Fixed by #22374
Labels
type/bug
Milestone
1.18.1

Comments

@somera
Copy link

somera commented Dec 30, 2022 •
edited
Loading

Description

After upgrade to 1.18.0 I see this

image

and I'm using an Nginx as reverse proxy, but this:

http://nuc-mini-pentium/times/stopwatch/toggle

will be not mapped. Under https://docs.gitea.io/en-us/reverse-proxies/ I can't see the new mappings.

Than I added

[service]
ENABLE_TIMETRACKING = false

but the feature stay visible.

How can I disable it? And which mappings should be added to nginx?

Gitea Version

1.18.0

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

2.39.0

Operating System

Ubuntu 20.04.5

How are you running Gitea?

Self hosted gitea-1.18.0-linux-amd64

Database

PostgreSQL
@lunny lunny added this to the 1.18.1 milestone Dec 31, 2022
@lunny lunny mentioned this issue Jan 9, 2023
Merged
techknowlogick pushed a commit that referenced this issue Jan 10, 2023
@lunny
Don't display stop watch top bar icon when disabled and hidden when c…
50f67d7 
…lick other place (#22374)

Fix #22286 

When timetracking is disabled, the stop watch top bar icon should be
hidden.
When the stop watch recording popup, it should be allowed to hide with
some operation. Now click any place on this page will hide the popup
window.
yardenshoham added a commit to yardenshoham/gitea that referenced this issue Jan 10, 2023
@yardenshoham
Don't display stop watch top bar icon when disabled and hidden when c…
04e0458 
…lick other place (go-gitea#22374)

Backport go-gitea#22374

Fix go-gitea#22286

When timetracking is disabled, the stop watch top bar icon should be hidden.
When the stop watch recording popup, it should be allowed to hide with some operation. Now click any place on this page will hide the popup window.
@yardenshoham yardenshoham mentioned this issue Jan 10, 2023
Merged
zeripath pushed a commit that referenced this issue Jan 10, 2023
@yardenshoham
Don't display stop watch top bar icon when disabled and hidden when c…
885082f 
…lick other place (#22374) (#22387)

Backport #22374

Fix #22286

When timetracking is disabled, the stop watch top bar icon should be
hidden. When the stop watch recording popup, it should be allowed to
hide with some operation. Now click any place on this page will hide the
popup window.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.18.1
Development

Successfully merging a pull request may close this issue.

Don't display stop watch top bar icon when disabled and hidden when click other place lunny/gitea
2 participants
@lunny @somera