Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When official review is deleted, previous review should become official #22406

Closed
jpraet opened this issue Jan 11, 2023 · 2 comments · Fixed by #22449
Closed

When official review is deleted, previous review should become official #22406

jpraet opened this issue Jan 11, 2023 · 2 comments · Fixed by #22449
Labels
type/bug
Milestone
1.18.1

Comments

@jpraet
Copy link
Member

jpraet commented Jan 11, 2023

Description

As stated here, only reviewers latest review of type approve and reject shall count as "official". So when submitting a new "official" review, the "official" status of existing reviews of that user are cleared.

However, when deleting a review (currently only possible through the API), the "official" status of the previous approval/rejection of that user is never restored.

Gitea Version

1.18.0

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

None
@lunny lunny added this to the 1.18.1 milestone Jan 12, 2023
@lunny
Copy link
Member

lunny commented Jan 12, 2023

Maybe we should disallow to delete an approval or reject review?

@jpraet
Copy link
Member Author

jpraet commented Jan 12, 2023

Maybe we should disallow to delete an approval or reject review?

I hope not. I use it in my workflow. We have a bot account that automatically submits approvals in some scenario's.
If the bot was triggered by mistake we use this functionality to delete the approval.

jpraet added a commit to jpraet/gitea that referenced this issue Jan 14, 2023
@jpraet
Restore previous official review when an official review is deleted
6649ff7 
Fix go-gitea#22406
@jpraet jpraet mentioned this issue Jan 14, 2023
Merged
lafriks added a commit to jpraet/gitea that referenced this issue Jan 15, 2023
@lafriks
Merge branch 'main' into go-gitea#22406-delete-review-restore-official
7aafa8f
lafriks added a commit that referenced this issue Jan 15, 2023
@jpraet @lafriks
Restore previous official review when an official review is deleted (#…
fe519d8 
…22449)

Fix #22406

Co-authored-by: Lauris BH <lauris@nix.lv>
jpraet added a commit to jpraet/gitea that referenced this issue Jan 15, 2023
@jpraet @lafriks
Restore previous official review when an official review is deleted (g…
6fe4555 
…o-gitea#22449)

Fix go-gitea#22406

Co-authored-by: Lauris BH <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.18.1
Development

Successfully merging a pull request may close this issue.

Restore previous official review when an official review is deleted jpraet/gitea
2 participants
@lunny @jpraet