Comment text lost when changing issue label #22603
Labels
Comments
brechtvl
added a commit
to brechtvl/gitea
that referenced
this issue
Jan 26, 2023
The no-store cache control added in go-gitea#20432 is causing form input to be cleared unnecessarily on page reload. Instead use max-age=0,private,must-revalidate which avoid this. This was particularly a problem when typing a long comment for an issue and then for example changing the label. The page would be reload and lose the unsubmitted comment. Fixes go-gitea#22603
jolheiser
pushed a commit
that referenced
this issue
Feb 1, 2023
…2604) The `no-store` cache control added in #20432 is causing form input to be cleared unnecessarily on page reload. Instead use `max-age=0,private,must-revalidate` which avoids this. This was particularly a problem when typing a long comment for an issue and then for example changing the label. The page would be reloaded and lose the unsubmitted comment. Fixes #22603
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
To reproduce:
If you've spent some time typing out a detailed comment, this is not ideal.
It was caused by #20432. Before that the comment was preserved.
Tested on Firefox 109, Ubuntu Linux 20.04.
Gitea Version
e8ac6a9 (main)
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
Built Gitea myself, and confirmed on try.gitea.io.
Database
None
The text was updated successfully, but these errors were encountered: