Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention python package index --extra-index-url potential dependency confusion attack in web-ui #22616

Closed
laundmo opened this issue Jan 27, 2023 · 1 comment · Fixed by #22620
Closed

Mention python package index --extra-index-url potential dependency confusion attack in web-ui #22616

laundmo opened this issue Jan 27, 2023 · 1 comment · Fixed by #22620
Labels
topic/packages topic/ui Change the appearance of the Gitea UI type/bug

Comments

@laundmo
Copy link

laundmo commented Jan 27, 2023

Description

Currently, Gitea suggests using the command pip install --extra-index-url <gitea-url> <packagename>. The --extra-index-url is susceptible to dependency confusion attacks, see: pypa/pip#8606
This suggested command also does not match the documented command which uses the --index-url <gitea-url> --no-deps flags.

This should be mentioned in the web-ui to make users aware of the potential security risks from using this for private packages.

Screenshots

image

Gitea Version

1.18.3

Can you reproduce the bug on the Gitea demo site?

No

Operating System

No response

Browser Version

Firefox 109.0
@laundmo laundmo added type/bug topic/ui Change the appearance of the Gitea UI labels Jan 27, 2023
@laundmo
Copy link
Author

laundmo commented Jan 27, 2023 •
edited
Loading

note: i set Can you reproduce the bug on the Gitea demo site? to No because i have not tried to reproduce it.

@KN4CK3R KN4CK3R mentioned this issue Jan 27, 2023
Merged
KN4CK3R added a commit that referenced this issue Jan 27, 2023
@KN4CK3R @zeripath
Use --index-url in PyPi description (#22620)
51a92cb 
Fixes #22616

Co-authored-by: zeripath <art27@cantab.net>
@yardenshoham yardenshoham mentioned this issue Jan 27, 2023
Merged
yardenshoham pushed a commit to yardenshoham/gitea that referenced this issue Jan 27, 2023
@KN4CK3R @zeripath @yardenshoham
Use --index-url in PyPi description (go-gitea#22620)
7c12b1e 
Fixes go-gitea#22616

Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/packages topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use --index-url in PyPi description go-gitea/gitea
2 participants
@KN4CK3R @laundmo