Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI misses the Tenant flag for the authentication source Azure AD v2 (OAuth2) #22713

Closed
Adito5393 opened this issue Feb 1, 2023 · 1 comment · Fixed by #22769
Closed

CLI misses the Tenant flag for the authentication source Azure AD v2 (OAuth2) #22713

Adito5393 opened this issue Feb 1, 2023 · 1 comment · Fixed by #22769
Assignees
Labels

Comments

@Adito5393
Copy link
Contributor

Adito5393 commented Feb 1, 2023

Description

The configuration of the Azure AD v2 source via the webpage works as expected:
image

However, via the CLI, there is no way to pass the tenant value. I can see the CustomURLMapping structure contains the Tenant value.

I can work on a PR if someone can indeed confirm that the following files need the updates:

Gitea Version

1.18.2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

2.36.4, Wire Protocol Version 2 Enabled

Operating System

Ubuntu 22.04.1 LTS (GNU/Linux 5.15.0-1026-kvm x86_64)

How are you running Gitea?

Running it in Docker version 20.10.23 from docker image gitea/gitea:1.18.2-rootless.

Database

PostgreSQL

@zeripath
Copy link
Contributor

zeripath commented Feb 1, 2023

You shouldn't need to edit providers_custom.go.

Just update the cmds and the docs.

Adito5393 added a commit to Adito5393/gitea that referenced this issue Mar 3, 2023
lunny added a commit that referenced this issue Mar 6, 2023
Backport #22769

Fixes #22713

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants