Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License oddity and copying code insteed of importing? #22758

Closed
KlavsKlavsen opened this issue Feb 4, 2023 · 0 comments · Fixed by #22765
Closed

License oddity and copying code insteed of importing? #22758

KlavsKlavsen opened this issue Feb 4, 2023 · 0 comments · Fixed by #22765
Labels

Comments

@KlavsKlavsen
Copy link

Description

I wanted to learn a bit more abotu the gitea registry implementation and found that it copies a lot of code, from the OpenContainers reference implementation.
the gitea OCI container registry implementation copies a lot of code (and has source code link such as ttps://github.com/opencontainers/image-spec/tree/main/specs-go/v1 directly above it.

But the license given in the file its copied to, is still stated at top to be MIT - but opencontainers implementation is Apache 2 license and AFAIK must not be copied without atleast including the apache2 license text and indicating the parts that belong to that license.
Thats how I understand https://www.gnu.org/licenses/license-compatibility.en.html

Should this perhaps not have been imported instead ? or copied as entire files to seperate folder in gitea repo and them imported - so it was easier to specify license?

This way it would also be much easier to detect when the gitea copies becomes out of date (due to newer releases in opencontainer ref. implementation) - and easier to update.

IANAL - but as a user of Gitea I care about its well being and wanted to highlight the issue, now that I stumbled over it.

Gitea Version

1.8.2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

in docker.

Database

None

zeripath pushed a commit that referenced this issue Feb 6, 2023
Fixes #22758

Otherwise we would need to rewrite the structs in `oci.go`.
KN4CK3R added a commit to KN4CK3R/gitea that referenced this issue Feb 7, 2023
Fixes go-gitea#22758

Otherwise we would need to rewrite the structs in `oci.go`.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant