Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full Width Files Changed View Unified #22781

Closed
gempir opened this issue Feb 6, 2023 · 0 comments · Fixed by #22844
Closed

Full Width Files Changed View Unified #22781

gempir opened this issue Feb 6, 2023 · 0 comments · Fixed by #22844
Labels
topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@gempir
Copy link
Contributor

gempir commented Feb 6, 2023

Feature Description

The "Files Changed" view already has a full width feature when using Split View for files. An option to also have this for Unified View would be very appreciated because when the file picker is open not a lot of space is left for the actual file and if it's a file with longer lines you have to horizontally scroll a lot.

Making use of the full screen real estate makes sense to me.

Github and Gitlab already do it this way.

Only question I have. Does this make sense to be configurable (Button to make it wide) or should it just always be full width.

Screenshots

How Github does it:
image

Current 1.18.3 gitea unified view:
image

Current 1.18.3 gitea split view:
image
@gempir gempir added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Feb 6, 2023
@lunny lunny added topic/ui Change the appearance of the Gitea UI and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Feb 6, 2023
This was referenced Feb 8, 2023
Closed
Merged
jolheiser pushed a commit that referenced this issue Feb 16, 2023
@gempir
Always go full width in PR view (#22844)
d9c6cb7 
This is an alternative solution to #22824 
and would also close #22781

This makes the PR diff view always full width.
It makes sense to make use of that screen real estate. If you want a
more narrow view you can always resize your browser.
It also avoids cluttering the UI with another button + the database with
another column for the setting.

This is also how github and gitlab do it.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
2 participants
@lunny @gempir