Pull Requests: add button to compare force pushed commits #22857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
GiteaBot
added
the
lgtm/need 2
techknowlogick
approved these changes
Feb 24, 2023
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Mar 1, 2023
| @@ -707,6 +707,11 @@ | |||
| {{$.locale.TrN (len .Commits) "repo.issues.push_commit_1" "repo.issues.push_commits_n" (len .Commits) $createdStr | Safe}} | |||
| {{end}} | |||
| </span> | |||
| {{if and .IsForcePush $.Issue.PullRequest.BaseRepo.Name}} | |||
| <span class="ui float right comparebox"> | |||
| <a href="{{$.Issue.PullRequest.BaseRepo.Link}}/compare/{{PathEscape .OldCommit}}..{{PathEscape .NewCommit}}" rel="nofollow" class="ui compare label">{{$.locale.Tr "repo.issues.force_push_compare"}}</a> | |||
There was a problem hiding this comment.
Ah, I already wondered how you would solve the problem that a force-pushed commit might have been deleted by Git GC. Your approach works of course, as it will simply display a 404 or similar…
I'm wondering: Should we perhaps open the comparison in a new tab?
You probably want to continue using this tab, if you're already taking the time to go through the individual commit history…
GiteaBot
added
lgtm/done
To quickly see what changed without having to re-read the whole diff.
techknowlogick
force-pushed
the
pr-force-push-compare
branch
from
03e90d3
to
dab464f
Compare
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 2, 2023
* giteaofficial/main: Fix commit retrieval by tag (go-gitea#21804) Fix missed `.hide` class (go-gitea#23208) [skip ci] Updated translations via Crowdin Add loading yaml label template files (go-gitea#22976) Allow `<video>` in MarkDown (go-gitea#22892) Pull Requests: add button to compare force pushed commits (go-gitea#22857) Do not create commit graph for temporary repos (go-gitea#23219) Use the correct selector to hide the checkmark of selected labels on clear (go-gitea#23224) Order pull request conflict checking by recently updated, for each push (go-gitea#23220) Fix incorrect checkbox behaviors in the dashboard repolist's filter (go-gitea#23147)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To quickly see what changed without having to re-read the whole diff.