Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue popup preview doesn't get dismissed soon enough #23073

Closed
dfelinto opened this issue Feb 22, 2023 · 3 comments · Fixed by #23169
Closed

Issue popup preview doesn't get dismissed soon enough #23073

dfelinto opened this issue Feb 22, 2023 · 3 comments · Fixed by #23169
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@dfelinto
Copy link
Contributor

Description

When we have multiple links to issues in a message and we mouse over one after the other the preview popups pile up.

Screenshots

image

Gitea Version

1.19.0+dev-557-g90a7bba1f

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

No response

Browser Version

Google Chrome
@dfelinto dfelinto added type/bug topic/ui Change the appearance of the Gitea UI labels Feb 22, 2023
@dfelinto
Copy link
Contributor Author

To see this in the test instance of Gitea go to: https://try.gitea.io/dfelinto/blender/issues/14

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 22, 2023 •
edited

It seems that the tippy popup must be hovered first, to make it could be hidden (mouseout) later .....

Hmm ... not related ....

Update: it seems that the tippy area is much larger, the mouse pointer could be moved to a far place, the tippy is still show.

That's why you can 3 popups at the same time: because the mouse pointer is still in all of their area ...... if you move the pointer slowly farther and farther, these popups will disappear one by one.

image

@wxiaoguang
Copy link
Contributor

The answer seems to be this:

https://atomiks.github.io/tippyjs/v6/all-props/#interactiveborder

Determines the size in pixels of the invisible border around a tippy which will prevent it from hiding if the cursor left it.

And Gitea set it to : interactiveBorder: 30

@HesterG HesterG mentioned this issue Feb 27, 2023
Merged
lunny added a commit that referenced this issue Mar 5, 2023
@HesterG @lunny
Change interactiveBorder to fix popup preview (#23169)
ea7f0d6 
Close #23073. 
Used the solution as reference to the reply:
#23073 (comment)
Here made the change inside the `contextpopup.js` because this is where
the popup component is created and tippy configuration is given.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@GiteaBot GiteaBot mentioned this issue Mar 5, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Mar 5, 2023
@HesterG @lunny @GiteaBot
Change interactiveBorder to fix popup preview (go-gitea#23169)
e43c119 
Close go-gitea#23073. 
Used the solution as reference to the reply:
go-gitea#23073 (comment)
Here made the change inside the `contextpopup.js` because this is where
the popup component is created and tippy configuration is given.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@GiteaBot GiteaBot mentioned this issue Mar 5, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Mar 5, 2023
@HesterG @lunny @GiteaBot
Change interactiveBorder to fix popup preview (go-gitea#23169)
75a82ea 
Close go-gitea#23073. 
Used the solution as reference to the reply:
go-gitea#23073 (comment)
Here made the change inside the `contextpopup.js` because this is where
the popup component is created and tippy configuration is given.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
lunny added a commit that referenced this issue Mar 6, 2023
@GiteaBot @HesterG @lunny
Change interactiveBorder to fix popup preview (#23169) (#23314)
d1d1530 
Backport #23169

Close #23073. 
Used the solution as reference to the reply:
#23073 (comment)
Here made the change inside the `contextpopup.js` because this is where
the popup component is created and tippy configuration is given.

Co-authored-by: Hester Gong <hestergong@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
jolheiser pushed a commit that referenced this issue Mar 6, 2023
@GiteaBot @HesterG
Change interactiveBorder to fix popup preview (#23169) (#23313)
93fe020 
Backport #23169

Close #23073. 
Used the solution as reference to the reply:
#23073 (comment)
Here made the change inside the `contextpopup.js` because this is where
the popup component is created and tippy configuration is given.

Co-authored-by: Hester Gong <hestergong@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change interactiveBorder to fix popup preview HesterG/gitea
2 participants
@dfelinto @wxiaoguang