Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add meilisearch support #23136

Merged
merged 16 commits into from
Mar 29, 2023
Merged

Add meilisearch support #23136

merged 16 commits into from
Mar 29, 2023

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Feb 25, 2023 •
edited
Loading

Add meilisearch support

Fixes #20665

@techknowlogick techknowlogick added type/feature Completely new functionality. Can only be merged if feature freeze is not active. pr/wip This PR is not ready for review labels Feb 25, 2023
@techknowlogick techknowlogick added this to the 1.20.0 milestone Feb 25, 2023
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 25, 2023 •
edited
Loading

I have a question: if one year later, another "better-search" comes, then Gitea will have 4 search engines? and then 5, 6, 7 ... more and more?

(just curious about the plan and the guideline about introducing new supports)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 25, 2023
@techknowlogick
Copy link
Member Author

I have a question: if one year later, another "better-search" comes, then Gitea will have 4 search engines? and then 5, 6, 7 ... more and more?

I think one of the great things about Gitea is the flexibility, such as we don't prescribe any certain database and allow users to choose the DB that they are most comfortable with. We have the abstract interface in issues search to support additional search engines. Perhaps when plugins are supported we can switch out this functionality to use a plugin, but I think in the shortterm this gives users that choice.

@techknowlogick techknowlogick removed the pr/wip This PR is not ready for review label Feb 25, 2023
@techknowlogick techknowlogick marked this pull request as ready for review February 25, 2023 04:48
lunny
lunny reviewed Mar 1, 2023
View reviewed changes
custom/conf/app.example.ini Outdated Show resolved Hide resolved
@codecov-commenter

This comment was marked as outdated.

Sign in to view
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 19, 2023
@silverwind
Copy link
Member

Does it make sense to also support it for the repo indexer?

@techknowlogick
Copy link
Member Author

@silverwind I think yes, but I was going to do that in a different PR once/if this is merged.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 28, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 29, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) March 29, 2023 01:58
@techknowlogick
Copy link
Member Author

ping lg-tm

@techknowlogick techknowlogick merged commit 92c160d into go-gitea:main Mar 29, 2023
@techknowlogick techknowlogick removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 29, 2023
@techknowlogick techknowlogick deleted the meilisearch-issue-search branch March 29, 2023 02:30
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 29, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
58ed503 
* upstream/main:
  Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (go-gitea#23687)
  Add CSS rules for basic colored labels (go-gitea#23774)
  Add meilisearch support (go-gitea#23136)
  Add missing translation for `actions.runners.reset_registration_token_success` (go-gitea#23732)
  [skip ci] Updated translations via Crowdin
  Implement Issue Config (go-gitea#20956)
  Set repository link based on the url in package.json for npm packages (go-gitea#20379)
  Add API to manage issue dependencies (go-gitea#17935)
  Add creation time in tag list page (go-gitea#23693)
  Make minio package support legacy MD5 checksum (go-gitea#23768)
  Yarden Shoham has a new email address (go-gitea#23767)
  fix br display for packages curls (go-gitea#23737)
@pat-s
Copy link
Member

pat-s commented Apr 2, 2023

@techknowlogick Could this also be used for the code indexer or is it limited to issue indexing for technical reasons?

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks left review comments

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

meilisearch search engine support
8 participants
@techknowlogick @wxiaoguang @codecov-commenter @silverwind @pat-s @lunny @lafriks @GiteaBot