Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish Review buttons should indicate why they are disabled #23598

Merged
merged 5 commits into from Mar 20, 2023
Merged

Publish Review buttons should indicate why they are disabled #23598

merged 5 commits into from Mar 20, 2023

Conversation

puni9869
Copy link
Member

@puni9869 puni9869 commented Mar 20, 2023 •
edited by jolheiser

Adding tooltip on "Approve" and "Review Changes" buttons. is try to do by them self on their PR.
Resolves #23547
Approve tootip text :- "Pull request authors can’t approve their own pull request"
Request Changes tooltip text:- "Pull request authors can’t request changes on their own pull request"

Before
https://user-images.githubusercontent.com/115237/225984020-306c048f-cb9b-4dee-8929-1c74c331518b.png

After
image

@puni9869 puni9869 changed the title Adding tooltip on "Approve" and "Review Changes" buttons. Adding tooltip on "Approve" and "Request Changes" buttons. Mar 20, 2023
@puni9869 puni9869 changed the title Adding tooltip on "Approve" and "Request Changes" buttons. Buttons in review box should indicate reason for disablement. Mar 20, 2023
@silverwind silverwind added the type/enhancement An improvement of existing functionality label Mar 20, 2023
@silverwind silverwind added this to the 1.20.0 milestone Mar 20, 2023
@silverwind
Copy link
Member

Note: Can't backport because of new translations.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 20, 2023
@silverwind silverwind added the topic/ui Change the appearance of the Gitea UI label Mar 20, 2023
jolheiser
jolheiser requested changes Mar 20, 2023
View reviewed changes
templates/repo/diff/new_review.tmpl Outdated Show resolved Hide resolved
options/locale/locale_en-US.ini Outdated Show resolved Hide resolved
@puni9869
Copy link
Member Author

Note: Can't backport because of new translations.

What should be my next step. Kinda new to process.

@puni9869 puni9869 changed the title Buttons in review box should indicate reason for disablement. [WIP] Buttons in review box should indicate reason for disablement. Mar 20, 2023
@puni9869 puni9869 marked this pull request as ready for review March 20, 2023 20:28
@silverwind
Copy link
Member

Note: Can't backport because of new translations.

What should be my next step. Kinda new to process.

Nothing from your side. Once the PR is merged in main, translations will start coming in over time from Crowdin. Once enough translations are there, we can opt to backport into 1.19, but as this is not a critical enhancement, I'd say it's not worth the effort.

@puni9869 puni9869 changed the title [WIP] Buttons in review box should indicate reason for disablement. Buttons in review box should indicate reason for disablement. Mar 20, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 20, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 20, 2023
@jolheiser jolheiser added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 20, 2023
delvh
delvh approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also prefer it if we didn't need the span.
However, as you mentioned that it is apparently a tippy "bug"/intended behavior, so I'll allow it.

@silverwind
Copy link
Member

I'd also prefer it if we didn't need the span. However, as you mentioned that it is apparently a tippy "bug"/intended behavior, so I'll allow it.

Yes, it is actually documented as well here:

https://github.com/atomiks/tippyjs/blob/4fbef2cb4e66ad240cc0a67936c7300fee16f03d/website/src/pages/v6/constructor.mdx#disabled-elements

@delvh delvh changed the title Buttons in review box should indicate reason for disablement. Publish Review buttons should indicate why they are disable Mar 20, 2023
@delvh delvh changed the title Publish Review buttons should indicate why they are disable Publish Review buttons should indicate why they are disabled Mar 20, 2023
@zeripath zeripath enabled auto-merge (squash) March 20, 2023 21:21
@zeripath zeripath merged commit a8c30a4 into go-gitea:main Mar 20, 2023
2 checks passed
@jolheiser jolheiser removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 20, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 21, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
d4f3fc7 
* upstream/main:
  Replace a few fontawesome icons with svg (go-gitea#23602)
  Fix pagination on `/notifications/watching` (go-gitea#23564)
  Fix `.locale.Tr` function not found in delete modal (go-gitea#23468)
  fix submodule is nil panic (go-gitea#23588)
  `Publish Review` buttons should indicate why they are disabled (go-gitea#23598)
  Improve template error reporting (go-gitea#23396)
  Polyfill the window.customElements (go-gitea#23592)
  Add CHANGELOG for 1.19.0 (go-gitea#23583)
@puni9869 puni9869 deleted the puni9869_fix-self-approve-review_change-tooltip branch March 21, 2023 05:09
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

@jolheiser jolheiser jolheiser approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

Buttons in review box should indicate reason for disablement
7 participants
@puni9869 @silverwind @yardenshoham @jolheiser @delvh @zeripath @GiteaBot