Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons in review box should indicate reason for disablement #23547

Closed
silverwind opened this issue Mar 17, 2023 · 4 comments · Fixed by #23598
Closed

Buttons in review box should indicate reason for disablement #23547

silverwind opened this issue Mar 17, 2023 · 4 comments · Fixed by #23598
Assignees
@puni9869
Labels
good first issue Likely to be an easy fix topic/ui Change the appearance of the Gitea UI topic/ui-interaction Change the process how users use Gitea instead of the visual appearance

Comments

@silverwind
Copy link
Member

silverwind commented Mar 17, 2023 •
edited
Loading

Description

When trying to review one's own PR, the UI buttons are disabled and there is no indication on why. I think a simple "You can not approve you own Pull Request" would go a long way in making it clear.

Screenshots

image
@silverwind silverwind added type/bug topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality topic/ui-interaction Change the process how users use Gitea instead of the visual appearance and removed type/bug labels Mar 17, 2023
@silverwind
Copy link
Member Author

silverwind commented Mar 17, 2023 •
edited
Loading

Alternatively, we could just hide the disabled button and only show the comment button like GitHub does:

image

I'd say this is even better than disabling the buttons as the user is visually driven to the now-gray "Submit Review" button.

@jolheiser
Copy link
Member

Alternatively, we could just hide the disabled button and only show the comment button like GitHub does:

I'd say this is even better than disabling the buttons as the user is visually driven to the now-gray "Submit Review" button.

Interesting, I still see the options, but they have tooltips for explanation
finish

@silverwind silverwind changed the title Review UI should indicate reason why buttons are disabled Buttons in review box need improvement Mar 17, 2023
@silverwind
Copy link
Member Author

silverwind commented Mar 17, 2023 •
edited
Loading

Ah yes, the screenshot above was from a already-merged PR. Open PR shows the same UI as you see, so yes I think we should indicate with tooltip on both the red and green button.

@silverwind silverwind added the good first issue Likely to be an easy fix label Mar 17, 2023
@silverwind silverwind changed the title Buttons in review box need improvement Buttons in review box should indicate reason for disablement Mar 17, 2023
@silverwind silverwind removed the type/enhancement An improvement of existing functionality label Mar 17, 2023
@puni9869
Copy link
Member

Could you assign this ticket to me.
This would be a good first issue for me. I have some experience with go and web development.

@puni9869 puni9869 mentioned this issue Mar 20, 2023
Merged
zeripath pushed a commit that referenced this issue Mar 20, 2023
@puni9869
Publish Review buttons should indicate why they are disabled (#23598)
a8c30a4 
Adding tooltip on "Approve" and "Review Changes" buttons. is try to do
by them self on their PR.
Resolves #23547
`Approve` tootip text :- "Pull request authors can’t approve their own
pull request"
`Request Changes` tooltip text:- "Pull request authors can’t request
changes on their own pull request"


Before 

https://user-images.githubusercontent.com/115237/225984020-306c048f-cb9b-4dee-8929-1c74c331518b.png

After 
<img width="841" alt="image"
src="https://user-images.githubusercontent.com/80308335/226445845-b5f6f6c9-f0dc-4934-a282-3b8be06417a8.png">
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@puni9869 puni9869

Labels
good first issue Likely to be an easy fix topic/ui Change the appearance of the Gitea UI topic/ui-interaction Change the process how users use Gitea instead of the visual appearance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Publish Review buttons should indicate why they are disabled puni9869/gitea
3 participants
@silverwind @jolheiser @puni9869