Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration test after librejs location change #2374

Merged
merged 1 commit into from
Aug 24, 2017
Merged

Fix integration test after librejs location change #2374

merged 1 commit into from
Aug 24, 2017

Conversation

strk
Copy link
Member

@strk strk commented Aug 23, 2017

Fixes #2373

@strk strk mentioned this pull request Aug 23, 2017
Closed
@MTecknology
Copy link
Contributor

MTecknology commented Aug 23, 2017 •
edited

Follow up: PR #2375

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 23, 2017
This was referenced Aug 23, 2017
Closed
Merged
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 24, 2017
@ethantkoenig
Copy link
Member

@strk You may want to rebase to rerun drone?

@MTecknology
Copy link
Contributor

@ethantkoenig It's not possible for tests to pass until #2375 is merged. If there are additional issues, I would like to address them in that PR.

@lafriks
Copy link
Member

lafriks commented Aug 24, 2017

LGTM but next time please fix the tests in same PR that breaks them

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 24, 2017
@lafriks lafriks merged commit 233bbcf into go-gitea:master Aug 24, 2017
@MTecknology
Copy link
Contributor

@lafriks Absolutely, I will.

@strk
Copy link
Member Author

strk commented Aug 24, 2017 via email

@strk strk deleted the librejs-link-test branch August 25, 2017 09:47
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failes since moving vendor dir files
5 participants
@strk @MTecknology @ethantkoenig @lafriks @tboerger