Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move themes to plugin directory. Fixes #2372 #2375

Merged
merged 1 commit into from
Aug 24, 2017
Merged

Move themes to plugin directory. Fixes #2372 #2375

merged 1 commit into from
Aug 24, 2017

Conversation

MTecknology
Copy link
Contributor

PR #2241 introduced a regression locating fonts.

The contents of public/css/assets/ were mistaken as original work and not moved into the correct vendor/ location. This PR moves these files to the correct location and closes #2372.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 23, 2017
@@ -1,21 +0,0 @@
MIT License
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

Copy link
Contributor Author

@MTecknology MTecknology Aug 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files are covered by the LICENSE file already present in the directory they were moved to. These files are part of that project. [context]

@MTecknology
Copy link
Contributor Author

Note: #2374 is causing the failed test; tests should pass if it is merged

@bkcsoft
Copy link
Member

bkcsoft commented Aug 24, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 24, 2017
@lafriks
Copy link
Member

lafriks commented Aug 24, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 24, 2017
@lafriks lafriks added this to the 1.3.0 milestone Aug 24, 2017
@lafriks lafriks merged commit 874f9be into go-gitea:master Aug 24, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon Fonts missing since moving vendor dir files
4 participants