Fix JS error when changing PR's target branch (#23862) #23864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caught by @justusbunsi An old bug from go-gitea#6488 In `pullrequest_targetbranch_change`, the `data` might be empty, because `UpdatePullRequestTarget` may respond `http.StatusNoContent`. And the old code's `$branchTarget.text(data.base_branch);` doesn't make sense, because in the end, the page will be always reloaded. So, just remove the `$branchTarget.text(data.base_branch);`, everything should be fine.
delvh
approved these changes
Apr 1, 2023
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
Apr 1, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
techknowlogick
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #23862 by @wxiaoguang
Caught by @justusbunsi
An old bug from #6488
In
pullrequest_targetbranch_change, thedatamight be empty, becauseUpdatePullRequestTargetmay respondhttp.StatusNoContent.And the old code's
$branchTarget.text(data.base_branch);doesn't make sense, because in the end, the page will be always reloaded.So, just remove the
$branchTarget.text(data.base_branch);, everything should be fine.