Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Change target branch for pull request #6488
This pull request aims to implement the feature in #6377 .
I'm new to Golang. So far the feature works, however there is still some work to do:
@@ Coverage Diff @@ ## master #6488 +/- ## ========================================== - Coverage 40.88% 40.85% -0.04% ========================================== Files 420 421 +1 Lines 57453 57561 +108 ========================================== + Hits 23490 23516 +26 - Misses 30837 30919 +82 Partials 3126 3126
Apr 2, 2019
The only thing that bugs me is that pull requests are nested inside issues...
After clicking the "Edit" button on a pull request page the user is able to change the title (as before) and select a new target branch from a select box. Since the title belongs to issues and the target branch belongs to a pull request there will be 2 HTTP requests. One setting the title via the existing issue endpoint and one setting the target branch via a new pull request endpoint. Which is also why two web hooks will be fired. :(