Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image border-radius #23886

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Fix image border-radius #23886

merged 3 commits into from
Apr 5, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Apr 3, 2023

  1. Instead of polluting the border-radius style globally, each "img" usage should declare their own styles.
  2. There were some bugs in code, I believe the .img selector was done by mistake.

After:

image

image

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 3, 2023
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Apr 3, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 3, 2023
@delvh delvh added this to the 1.20.0 milestone Apr 3, 2023
@delvh delvh added outdated/backport/v1.19 This PR should be backported to Gitea 1.19 reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Apr 3, 2023
@6543 6543 enabled auto-merge (squash) April 3, 2023 23:31
@6543 6543 removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 3, 2023
@6543 6543 disabled auto-merge April 5, 2023 00:44
@6543 6543 merged commit 376396a into go-gitea:main Apr 5, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 5, 2023
1. Instead of polluting the `border-radius` style globally, each "img"
usage should declare their own styles.
2. There were some bugs in code, I believe the `.img` selector was done
by mistake.

After:


![image](https://user-images.githubusercontent.com/2114189/229415742-161b018f-14c3-471d-bcf7-34f83e5c2d89.png)


![image](https://user-images.githubusercontent.com/2114189/229415789-829d364a-76da-47a5-8c61-398cc990873c.png)
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Apr 5, 2023
@wxiaoguang wxiaoguang deleted the fix-img-style branch April 5, 2023 02:37
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 5, 2023
* giteaoffical/main:
  Fix image border-radius (go-gitea#23886)
  [skip ci] Updated translations via Crowdin
  Scroll collapsed file into view (go-gitea#23702)
  docs: make the required backticks in email password more explicit (go-gitea#23923)
  docs: fix typo (go-gitea#23924)
  Update docs markdown file weight to make it clear (go-gitea#23909)
  Add activity feeds API (go-gitea#23494)
  Fix code view (diff) broken layout (go-gitea#23096)
  Use ghost user if package creator does not exist (go-gitea#23822)
  Org pages style fixes (go-gitea#23901)
  User/Org Feed render description as per web (go-gitea#23887)
KN4CK3R pushed a commit that referenced this pull request Apr 5, 2023
Backport #23886 by @wxiaoguang

1. Instead of polluting the `border-radius` style globally, each "img"
usage should declare their own styles.
2. There were some bugs in code, I believe the `.img` selector was done
by mistake.

After:


![image](https://user-images.githubusercontent.com/2114189/229415742-161b018f-14c3-471d-bcf7-34f83e5c2d89.png)


![image](https://user-images.githubusercontent.com/2114189/229415789-829d364a-76da-47a5-8c61-398cc990873c.png)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants