Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "inverted" class on creating new label and cancel buttons #24030

Merged
merged 3 commits into from Apr 10, 2023
Merged

Remove "inverted" class on creating new label and cancel buttons #24030

merged 3 commits into from Apr 10, 2023

Conversation

HesterG
Copy link
Contributor

@HesterG HesterG commented Apr 10, 2023 •
edited

"inverted" class might not be needed because background of these two buttons is light color.

inverted related rule from semantic.css:

.ui.inverted.green.basic.buttons .button,
.ui.inverted.green.buttons .basic.button,
.ui.inverted.green.basic.button {
  background-color: transparent;
  box-shadow: 0 0 0 2px rgba(255, 255, 255, 0.5) inset;
  color: #FFFFFF;
}

Before:
截屏2023-04-10 17 21 22

After:
截屏2023-04-10 17 22 14

delvh
delvh approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, also looks better on arc-green now:
image

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 10, 2023
silverwind
silverwind approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.19 unaffected it seems.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 10, 2023
@silverwind silverwind added type/bug and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Apr 10, 2023
@silverwind silverwind added this to the 1.20.0 milestone Apr 10, 2023
@silverwind silverwind added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Apr 10, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 10, 2023
@lunny lunny merged commit f9d6092 into go-gitea:main Apr 10, 2023
1 check passed
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 10, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 11, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
41a79d0 
* upstream/main:
  Avoid recursing into sub-sub-sub-docs folders when looking for READMEs. (go-gitea#23695)
  [skip ci] Updated translations via Crowdin
  Use auto-updating, natively hoverable, localized time elements (go-gitea#23988)
  Reserve ".png" suffix for user/org names (go-gitea#23992)
  Allow adding SSH keys even if SSH server is disabled (go-gitea#24025)
  Add placeholder and aria attributes to release and wiki edit page (go-gitea#24031)
  Add --quiet option to gitea dump (go-gitea#22969)
  Remove "inverted" class on creating new label and cancel buttons (go-gitea#24030)
  Use actions job link as commit status URL instead of run link (go-gitea#24023)
  Make label templates have consistent behavior and priority (go-gitea#23749)
  Add actions support to package auth verification (go-gitea#23729)
@HesterG HesterG deleted the remove-inverted branch April 12, 2023 04:04
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@HesterG @silverwind @yardenshoham @delvh @lunny @GiteaBot