Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use actions job link as commit status URL instead of run link #24023

Merged
merged 3 commits into from
Apr 10, 2023
Merged

Use actions job link as commit status URL instead of run link #24023

merged 3 commits into from
Apr 10, 2023

Conversation

wolfogre
Copy link
Member

@wolfogre wolfogre commented Apr 9, 2023

A commit status is bound to a job, not a run.

@wolfogre wolfogre added type/bug topic/gitea-actions related to the actions of Gitea outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Apr 9, 2023
@wolfogre wolfogre added this to the 1.20.0 milestone Apr 9, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 9, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 9, 2023
@silverwind
Copy link
Member

Lint issue

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2023 •
edited
Loading

Codecov Report

Merging #24023 (7bebe8b) into main (f521e88) will decrease coverage by 0.11%.
The diff coverage is 30.78%.

@@            Coverage Diff             @@
##             main   #24023      +/-   ##
==========================================
- Coverage   47.14%   47.03%   -0.11%     
==========================================
  Files        1149     1163      +14     
  Lines      151446   153757    +2311     
==========================================
+ Hits        71397    72323     +926     
- Misses      71611    72916    +1305     
- Partials     8438     8518      +80
Impacted Files Coverage Δ
cmd/dump.go 0.66% <0.00%> (-0.01%) ⬇️
cmd/mailer.go 0.00% <0.00%> (ø)
cmd/manager.go 0.00% <0.00%> (ø)
cmd/manager_logging.go 0.00% <0.00%> (ø)
cmd/migrate_storage.go 5.76% <0.00%> (-0.12%) ⬇️
cmd/restore_repo.go 0.00% <0.00%> (ø)
cmd/web.go 0.00% <0.00%> (ø)
models/actions/run.go 1.63% <0.00%> (-0.10%) ⬇️
models/actions/runner.go 1.44% <ø> (ø)
models/organization/org_user.go 80.51% <0.00%> (-12.02%) ⬇️
... and 64 more

... and 109 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@silverwind silverwind enabled auto-merge (squash) April 10, 2023 09:43
@silverwind silverwind merged commit 8cbc4a3 into go-gitea:main Apr 10, 2023
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.19. @wolfogre, please send one manually. 🍵

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Apr 10, 2023
@wolfogre wolfogre mentioned this pull request Apr 10, 2023
Merged
@wolfogre wolfogre added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Apr 10, 2023
jolheiser pushed a commit that referenced this pull request Apr 10, 2023
@wolfogre
Use actions job link as commit status URL instead of run link (#24023) (
f55fe98 
#24032)

Backport #24023.

A commit status is bound to a job, not a run.
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 11, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
41a79d0 
* upstream/main:
  Avoid recursing into sub-sub-sub-docs folders when looking for READMEs. (go-gitea#23695)
  [skip ci] Updated translations via Crowdin
  Use auto-updating, natively hoverable, localized time elements (go-gitea#23988)
  Reserve ".png" suffix for user/org names (go-gitea#23992)
  Allow adding SSH keys even if SSH server is disabled (go-gitea#24025)
  Add placeholder and aria attributes to release and wiki edit page (go-gitea#24031)
  Add --quiet option to gitea dump (go-gitea#22969)
  Remove "inverted" class on creating new label and cancel buttons (go-gitea#24030)
  Use actions job link as commit status URL instead of run link (go-gitea#24023)
  Make label templates have consistent behavior and priority (go-gitea#23749)
  Add actions support to package auth verification (go-gitea#23729)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 topic/gitea-actions related to the actions of Gitea type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
7 participants
@wolfogre @silverwind @codecov-commenter @GiteaBot @lunny @yardenshoham @a1012112796