error deprecat argment check #24057
Labels
Comments
|
It's a lucky bug. It found in my codeql query。 |
|
It's not a bug, it's a useless code. |
lunny
pushed a commit
that referenced
this issue
Dec 5, 2023
close #24057 call stack: https://github.com/go-gitea/gitea/blob/25faee3c5f5be23c99b3b7e50418fc0dbad7a41b/routers/api/v1/repo/release.go#L154 https://github.com/go-gitea/gitea/blob/ec1feedbf582b05b6a5e8c59fb2457f25d053ba2/routers/api/v1/utils/page.go#L13-L18 https://github.com/go-gitea/gitea/blob/ec1feedbf582b05b6a5e8c59fb2457f25d053ba2/services/convert/utils.go#L15-L22 ##⚠️ Breaking⚠️ (though it's not caused by this PR) Do not use `per_page` to specify pagination; use `limit` instead
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this issue
Jan 17, 2024
close go-gitea#24057 call stack: https://github.com/go-gitea/gitea/blob/25faee3c5f5be23c99b3b7e50418fc0dbad7a41b/routers/api/v1/repo/release.go#L154 https://github.com/go-gitea/gitea/blob/ec1feedbf582b05b6a5e8c59fb2457f25d053ba2/routers/api/v1/utils/page.go#L13-L18 https://github.com/go-gitea/gitea/blob/ec1feedbf582b05b6a5e8c59fb2457f25d053ba2/services/convert/utils.go#L15-L22 ##⚠️ Breaking⚠️ (though it's not caused by this PR) Do not use `per_page` to specify pagination; use `limit` instead
silverwind
pushed a commit
to silverwind/gitea
that referenced
this issue
Feb 20, 2024
close go-gitea#24057 call stack: https://github.com/go-gitea/gitea/blob/25faee3c5f5be23c99b3b7e50418fc0dbad7a41b/routers/api/v1/repo/release.go#L154 https://github.com/go-gitea/gitea/blob/ec1feedbf582b05b6a5e8c59fb2457f25d053ba2/routers/api/v1/utils/page.go#L13-L18 https://github.com/go-gitea/gitea/blob/ec1feedbf582b05b6a5e8c59fb2457f25d053ba2/services/convert/utils.go#L15-L22 ##⚠️ Breaking⚠️ (though it's not caused by this PR) Do not use `per_page` to specify pagination; use `limit` instead
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
in code.
because convert.ToCorrectPageSize, listOptions.PageSize never is 0
Gitea Version
aa4d1d9
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
make && /gitea web
Database
None
The text was updated successfully, but these errors were encountered: