Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The size of create action runner button is too big #24326

Closed
yp05327 opened this issue Apr 25, 2023 · 1 comment · Fixed by #24338
Closed

The size of create action runner button is too big #24326

yp05327 opened this issue Apr 25, 2023 · 1 comment · Fixed by #24338
Assignees
@silverwind
Labels
type/bug

Comments

@yp05327
Copy link
Contributor

yp05327 commented Apr 25, 2023

Description

Maybe it is too big
image
Other buttons in website settings:
image
image
image

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build

Database

None
@silverwind
Copy link
Member

Yes, needs same size classes as other buttons to fit inside these headers.

@silverwind silverwind self-assigned this Apr 25, 2023
@silverwind silverwind mentioned this issue Apr 25, 2023
Merged
techknowlogick pushed a commit that referenced this issue Apr 26, 2023
@silverwind
Fix runner button height (#24338)
75e35fb 
Fixes #24326.

Set size class and downsize any such buttons that have a dropdown icon
because the dropdown icon increases button height artificially.

[`:has()`](https://developer.mozilla.org/en-US/docs/Web/CSS/:has) is not
supported in Firefox yet, but works fine with the experimental pref
enabled. I see this as a graceful degradation in unsupporting browsers.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@silverwind silverwind

Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix runner button height silverwind/gitea
2 participants
@silverwind @yp05327