Actions , being not enabled, appears in Team settings #24449
Assignees
Labels
topic/gitea-actions
related to the actions of Gitea
topic/ui
Change the appearance of the Gitea UI
type/bug
Comments
lunny
pushed a commit
that referenced
this issue
May 5, 2023
close #24449 The unit of `Actions` should be contorlled not only by `repository.DISABLED_REPO_UNITS` but also by `actions.ENABLED` in the `app.ini`. Previously, the permission of the team's `Actions` unit was not controlled by `actions.Enabled`. So, even if the user sets `actions.Enabled` to false, he can still select the permission of the `Actions` unit for the team. This PR makes the permissions of the team's `Actions` unit also controlled by `actions.Enabled`. Just append`TypeActions` into `DisabledRepoUnits` slice when initializing if `actions.Enabled` is false. ### Changes: If `Actions` is set disbaled in `app.ini`, like below: ```yaml [actions] ENABLED = false ``` 1. If user try to create/edit a team, will prompt user that `Actions` is disabled.  2. `actions` is not displayed in the sidebar on the team details page 
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this issue
May 5, 2023
close go-gitea#24449 The unit of `Actions` should be contorlled not only by `repository.DISABLED_REPO_UNITS` but also by `actions.ENABLED` in the `app.ini`. Previously, the permission of the team's `Actions` unit was not controlled by `actions.Enabled`. So, even if the user sets `actions.Enabled` to false, he can still select the permission of the `Actions` unit for the team. This PR makes the permissions of the team's `Actions` unit also controlled by `actions.Enabled`. Just append`TypeActions` into `DisabledRepoUnits` slice when initializing if `actions.Enabled` is false. ### Changes: If `Actions` is set disbaled in `app.ini`, like below: ```yaml [actions] ENABLED = false ``` 1. If user try to create/edit a team, will prompt user that `Actions` is disabled.  2. `actions` is not displayed in the sidebar on the team details page 
silverwind
pushed a commit
that referenced
this issue
May 5, 2023
Backport #24536 by @sillyguodong close #24449 The unit of `Actions` should be contorlled not only by `repository.DISABLED_REPO_UNITS` but also by `actions.ENABLED` in the `app.ini`. Previously, the permission of the team's `Actions` unit was not controlled by `actions.Enabled`. So, even if the user sets `actions.Enabled` to false, he can still select the permission of the `Actions` unit for the team. This PR makes the permissions of the team's `Actions` unit also controlled by `actions.Enabled`. Just append`TypeActions` into `DisabledRepoUnits` slice when initializing if `actions.Enabled` is false. ### Changes: If `Actions` is set disbaled in `app.ini`, like below: ```yaml [actions] ENABLED = false ``` 1. If user try to create/edit a team, will prompt user that `Actions` is disbaled.  2. `actions` is not displayed in the sidebar on the team details page  Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
I have no Actions enabled, but when I navigate to particular team there is a mention of Actions permission
Screenshots
Gitea Version
1.19.1
Can you reproduce the bug on the Gitea demo site?
No
Operating System
No response
Browser Version
112
The text was updated successfully, but these errors were encountered: