List a team's member API page parameter is 0-based (should be 1-based)
#24747
Labels
issue/confirmed
Issue has been reviewed and confirmed to be present or accepted to be implemented
type/bug
Milestone
Comments
|
The fix would be a breaking change so this shouldn't go in 1.19.4 |
|
It should be a bug, because the API documentation said it's 1 based. |
|
I agree it's a bug. The fix itself would be a breaking change so it should be fixed in 1.20 |
yardenshoham
added
the
issue/confirmed
lunny
pushed a commit
that referenced
this issue
May 17, 2023
Now it's 1-based instead of 0-based - Fixes #24747 ### Before  ### After  ##⚠️ BREAKING⚠️ Previous API consumers may have relied on the 0-based pagination of this endpoint. The page numbering now starts at 1, as documented. Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Codeberg-org
pushed a commit
to Codeberg-org/gitea
that referenced
this issue
Jul 5, 2023
Now it's 1-based instead of 0-based - Fixes go-gitea#24747   Previous API consumers may have relied on the 0-based pagination of this endpoint. The page numbering now starts at 1, as documented. Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
In the API specification,
pageis supposed to be specified as1-based.https://try.gitea.io/api/swagger#/organization/orgListTeamMembers
However, it seems to be implemented with
0-based. (Please see screenshots)Gitea Version
1.19.3
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
Target Organization/Team
Result when
page=1is specifiedResult when
page=0is specifiedGit Version
No response
Operating System
No response
How are you running Gitea?
Installed with Helm chart and running on Kubernetes.
Override values
Install command
Database
None
The text was updated successfully, but these errors were encountered: